Skip to content

Conversation

tirth23
Copy link
Contributor

@tirth23 tirth23 commented Jul 10, 2025

Closes # MASMON-3198

Summary

  • Add drag and drop for image hotspot

Change List (commits, features, bugs, etc)

  • feat: add drag and drop for image hotspot

Acceptance Test (how to verify the PR)

  • tests here

Regression Test (how to make sure this PR doesn't break old functionality)

  • tests here
image

Things to look for during review

  • Make sure all references to iot or bx class prefix is using the prefix variable
  • (React) All major areas have a data-testid attribute. New test ids should have test written to ensure they are not changed or removed.
  • UI should be checked in RTL mode to ensure the proper handling of layout and text.
  • All strings should be translatable.
  • The code should pass a11y scans (The storybook a11y knob should show no violations). New components should have a11y test written.
  • Unit test should be written and should have a coverage of 90% or higher in all areas.
  • All components should be passing visual regression test. For new styles or components either a visual regression test should be written for all permutations or the base image updated.
  • Changes or new components should either write new or update existing documentation.
  • PR should link and close out an existing issue

Copy link

netlify bot commented Jul 10, 2025

Deploy Preview for carbon-addons-iot-react ready!

Name Link
🔨 Latest commit 8b329f3
🔍 Latest deploy log https://app.netlify.com/projects/carbon-addons-iot-react/deploys/68dd03b48d267000084fdd49
😎 Deploy Preview https://deploy-preview-3992--carbon-addons-iot-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@tirth23 tirth23 force-pushed the add-drag-image-hotspot branch from 7d9383e to 059281b Compare July 11, 2025 10:30
@herleraja herleraja force-pushed the add-drag-image-hotspot branch from 059281b to 7ae7e79 Compare August 19, 2025 09:15
@herleraja herleraja requested a review from simson1 as a code owner August 19, 2025 09:15
@simson1 simson1 force-pushed the add-drag-image-hotspot branch from 7ae7e79 to 8b329f3 Compare October 1, 2025 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants