Skip to content

[MRG] Fix issues in utils.py, code optimisations, readability improvements, improvement in unit test coverage. #527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[MRG] Fix issues in utils.py, code optimisations, readability improvements, improvement in unit test coverage. #527

wants to merge 1 commit into from

Conversation

@python3-dev
Copy link
Contributor

CHANGES

utils.py

  • Fix import-error from pdfminer
  • Add type-annotations
  • Code optimisations random_string(), remove_extra(), text_strip(), compute_whitespace()
  • Improve code-readability.
  • Add more unit-test cases.

@vinayak-mehta @bosd: All tests are passing.

@bosd
Copy link
Collaborator

bosd commented Mar 4, 2025

@python3-dev Thanks for you contribution. Tests are failling sadly.
Can you look into this 🙏

@python3-dev @bosd
CHANGES
1c31d2a 
=======

utils.py

- Fix import-error from pdfminer
- Add type-annotations
- Code optimisations random_string(), remove_extra(), text_strip(),
    compute_whitespace()
- Improve code-readability.
- Add more unit-test cases.
@DoomedJupiter
Copy link
Collaborator

@python3-dev the failed test for python 3.8 is due to syntax that was first supported in 3.9 (see here). Possible solutions that involve cutting back on the syntax here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@python3-dev @bosd @DoomedJupiter