[fud2] Json Parser for Serialized Plans #2564
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
Adds a new planner, json. This reads from stdin one plan specified in the JSON form of flang. Additionally adds one new mode, json-plan. This takes the plan from the current planner and writes it to stdout in JSON syntax.
jku20
force-pushed
the
fud2/json-flang-parser
branch
from
f5dc6d3 to
629aad0
Compare
sampsyo
reviewed
Oct 17, 2025
fud2/fud-core/src/exec/driver.rs
Outdated
| let ast = serde_json::from_str(&input); | ||
| match ast { | ||
| Err(e) => { | ||
| eprintln!("error: {e}"); |
There was a problem hiding this comment.
Maybe this (and the one above) should just panic? Not sure this is really a recoverable type of error.
There was a problem hiding this comment.
It isn't really recoverable, but I don't think a panic is the right move here. It's very easy for a user to trigger this (for example putting gibberish as input to the json planner). My understanding is it's generally bad style to panic (opposed to printing some error message) on response to any user's input.
4 tasks
KarlJoad
added a commit
to Chil-HW/chil
that referenced
this pull request
Oct 22, 2025
This TODO was prompted by Calyx's fud2 adding serialization and deserialization support in [1], with an initial implementation in [2]. [1] calyxir/calyx#2555 [2] calyxir/calyx#2564
KarlJoad
added a commit
to Chil-HW/chil
that referenced
this pull request
Oct 25, 2025
This TODO was prompted by Calyx's fud2 adding serialization and deserialization support in [1], with an initial implementation in [2]. [1] calyxir/calyx#2555 [2] calyxir/calyx#2564
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This serializes fud2 using JSON and a language called flang. See #2555 for more details. In short this PR adds one new planner:
json. It reads a plan from stdin specified in the JSON form of flang.Additionally the PR adds one new mode:
json-plan, taking the plan from the current planner and writing it to stdout in JSON syntax of flang.