ament_target_dependencies is deprecated for Kilted and Rolling #22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @Timple to have this PR merged in off_highway_sensor_drivers we would need to request that you sign off you commit as stated in CONTRIBUTING.md |
This syntax should work as of ROS 2 Foxy already Signed-off-by: Tim Clephas <tim.clephas@nobleo.nl>
Timple
force-pushed
the
deprecate/ament_target_dependencies
branch
from
b7c49ab to
7273001
Compare
|
Done, also fixed the merge conflict. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This syntax should work as of ROS 2 Foxy already
Easy migration as this comes from the deprecation messages in Kilted.