Fix issue 20, don't publish sensor data when there is a sensor timeout #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @MCFurry, thanks for the PR. We will review and test it internally. |
|
Hello @MCFurry to have this PR merged in off_highway_sensor_drivers we would need to request that you sign off you commits as stated in CONTRIBUTING.md |
added 2 commits
September 18, 2025 09:10
Signed-off-by: Ferry Schoenmakers <ferry.schoenmakers@nobleo.nl>
Signed-off-by: Ferry Schoenmakers <ferry.schoenmakers@nobleo.nl>
MCFurry
force-pushed
the
fix/20-dont-publish-in-timeout
branch
from
160319b to
7509df2
Compare
Done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By storing the check for timeout result, the publishers can easily check and decide not to publish.
This way receiving nodes know about a timeout situation, similar to how Lidars do this.