Skip to content

fix: filegroup circular deps #164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: filegroup circular deps #164

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7c615ee
chore: remove reduntant `:data`
birunts Oct 25, 2025
a9e67d1
fix: filegroup circular deps
birunts Oct 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions apt/private/deb_translate_lock.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ alias(

filegroup(
name = "{target_name}",
srcs = select({deps}) + [":data"],
srcs = select({deps}),
visibility = ["//visibility:public"],
)
'''
Expand Down Expand Up @@ -192,7 +192,7 @@ def _deb_translate_lock_impl(rctx):
control_targets = '"@%s//:control"' % repo_name,
src = '"@%s//:data"' % repo_name,
deps = starlark_codegen_utils.to_list_attr([
"//%s/%s" % (dep["name"], package["arch"])
"//%s/%s:data" % (dep["name"], package["arch"])
for dep in package["dependencies"]
]),
urls = package["urls"],
Expand Down