fix:bug(prompts): fix error when truncating prompt description written in multibyte characters #3020
+94
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Replace byte-based string slicing with character-based truncation - Prevents panic when truncating multibyte characters (Korean, etc.) - Add comprehensive test coverage for UTF-8 boundary cases - Fix existing test compilation errors by adding missing fields
h16rkim
changed the title
h16rkim
changed the title
h16rkim
changed the title
h16rkim
changed the title
h16rkim
force-pushed
the
fix/prompt-description-truncate
branch
from
80f77f5 to
f6e0ab2
Compare
h16rkim
changed the title
…n-truncate # Conflicts: # crates/chat-cli/src/cli/chat/cli/prompts.rs
h16rkim
changed the title
…prove CJK character handling
h16rkim
commented
Oct 6, 2025
| /// Truncates text to a maximum display width. | ||
| /// Takes into account the display width of characters, where CJK characters are counted as 2 units | ||
| /// wide. Returns the truncated text without ellipsis. | ||
| pub fn truncate_safe_with_width(text: &str, max_width: usize) -> String { |
There was a problem hiding this comment.
In languages such as CJK, the width of a single character is twice of an alphabet letter. The code has been improved to correctly calculate the width even when the description is written in a CJK language.
h16rkim
force-pushed
the
fix/prompt-description-truncate
branch
from
065f251 to
3c1ee5a
Compare
h16rkim
force-pushed
the
fix/prompt-description-truncate
branch
from
3c1ee5a to
fe3fc2c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #3117
Error Screenshot
Description of changes:
This issue does not occur in the currently released version(1.16.2). However, it can be reproduced on the current main branch.This error is occuring in the current released version (1.17.1)When executing the
/prompts listcommand, there is a function that trims the description if it is too long. However, if the trim happens at the boundary of a multibyte character, a panic occurs and the program terminates.This PR fixes an issue that may occur in multibyte language systems such as Korean, Japanese, Chinese, Vietnamese, Thai, Arabic, emojis, etc..
After Applying this PR (Screenshot)
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.