feat: Typing "quit" or "exit" without slash also terminates session #2987
+47
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kensave
reviewed
Oct 2, 2025
| skip_printing_tools: false, | ||
| }) | ||
| } else if matches!(input.to_lowercase().as_str(), "exit" | "quit") { | ||
| return Ok(ChatState::Exit); |
There was a problem hiding this comment.
I have second thoughts about this one as user could legitimately want to use this as a prompt.
There was a problem hiding this comment.
That's a possibility. It feels like "exit" though would be a stronger indicator than "quit" that the user wanted to end the session. I can update the PR to only look for "exit" if you agree.
For "quit", could we look at data to verify? For example, what's the percentage of chats that have "quit" followed by "/quit" or "/exit"?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
None
Description of changes:
Added support for exit and quit commands (without the slash) to terminate the chat session. Keeps feature parity with other agents. Saves expensive call to model when users intends to quit the session but doesn't use the slash.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.