Skip to content

Conversation

@Ananta2003
Copy link

Description:
This PR introduces a custom options page for user-defined settings within the Chrome extension. The page allows users to configure the following settings:

  • Enable Auto-Save: A checkbox to toggle auto-save functionality.
  • Custom Command: An input field to define a user-specific command.
  • Theme Selector: A dropdown to choose between light and dark themes, with dynamic theme switching.

Key Changes:

  • Created an options page with form fields for the above settings.
  • Implemented options.js for handling the saving and loading of user preferences using chrome.storage.local.
  • Added theme switching functionality (light/dark mode) based on user selection.
  • Ensured settings persist and are restored upon page load.

Testing:

  • Verified that settings are correctly saved and retrieved from chrome.storage.local.
  • Tested the theme switching functionality to ensure the correct theme is applied on both selection and page reload.
  • Tested responsiveness and UX for various screen sizes.

Related Issue:
Closes #20

@atj393 atj393 self-requested a review October 15, 2024 20:31
@atj393
Copy link
Owner

atj393 commented Oct 15, 2024

@Ananta2003 I will review it in two and let you know. Thanks for your patience.

Copy link
Owner

@atj393 atj393 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Ananta2003 ,

Thanks for your great work. Your contributions are greatly appreciated.

I have a few questions about the new functionalities:

Could you please provide a comprehensive list of all the new features added, including the Dark-Lite Theme mode?
I'm a bit unclear about the "Enable Auto-Save & Custom Command" features. Could you please elaborate on their functionality and how they will be implemented?
Regarding "Enable Auto-Save," if the feature automatically saves user data, it would be helpful to inform users beforehand and provide a clear warning or confirmation message. Additionally, updating the documentation to reflect this change would be beneficial.
For "Custom Command," could you please explain the specific use cases and how users can customize commands?
I also have a few suggestions:

Consider renaming the "Options" page to "Settings" for better clarity.
It might be more user-friendly to display the Options page as a small HTML popup directly below the extension, rather than opening it in a full-page window.
Please let me know your thoughts on these suggestions.

Thanks, @atj393

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Enhancement] Implement an Options Page for Custom Settings

2 participants