Fix MCP client multiple connections issue #7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When using multiple MCP clients in tinyagent, closing one client would cause an error in other active clients:
Root Cause
The issue was caused by improper isolation between multiple MCP client instances when using
AsyncExitStack
. When multiple clients shared the same event loop, closing one client would interfere with the context management of other active clients.Solution
This PR implements a comprehensive fix for the MCP client to support multiple concurrent connections:
Key Improvements
ConnectionState
enum for proper state trackingasync with
)Changes Made
ConnectionState
enum to track client state_connection_lock
usingasyncio.Lock()
for thread-safe operationsclose()
method with proper isolation and error handlingis_connected
property and connection state validation__aenter__
and__aexit__
for async context manager support_cleanup_connection()
method for safer resource cleanupBackward Compatibility
✅ Fully backward compatible - existing code will continue to work without changes
✅ No additional dependencies - keeps tinyagent lightweight
✅ Same API - all existing methods work as before
Testing
The implementation includes comprehensive examples demonstrating:
Example Usage
This fix resolves the cancel scope error and enables robust multiple MCP client usage in tinyagent applications.