fix(awssqs): include MessageGroupId in SQS SendMessage request #391
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The MessageGroupId was being processed in templating but not actually used when sending messages to SQS. This fix ensures that when a MessageGroupId is specified in the notification template, it's properly included in the SendMessageInput, which is required for FIFO queues. - Add MessageGroupId to SendMessageInput when available - Add unit tests to verify MessageGroupId inclusion/exclusion behavior - Fix ensures proper FIFO queue message grouping functionality Signed-off-by: Tommy Kim <tommy.kim@chime.com>
|
@blakepettersson sorry for the spam - you seem to be the most recently-active maintainer in the project 😅 This fix would really help my team. Are you available to review it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #342
The MessageGroupId was being processed in templating but not actually used when sending messages to SQS. This fix ensures that when a MessageGroupId is specified in the notification template, it's properly included in the SendMessageInput, which is required for FIFO queues.