Skip to content

Ensure function iterates over all results from google #507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Ensure function iterates over all results from google #507

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6bb2c7c
Ensure function iterates over all results from google
marcusramberg Sep 20, 2022
cc877b5
Merge branch 'main' into marcus/user_paging
marcusramberg Oct 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 18 additions & 11 deletions src/google.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,24 +26,31 @@ export async function getAdminService() {

export async function getGithubUsersFromGoogle(): Promise<Set<string>> {
const service = await mod.getAdminService()
let githubAccounts = new Set<string>()
let pageToken = null

const userList = await service.users.list({
customer: 'my_customer',
maxResults: 250,
projection: 'custom',
fields: 'users(customSchemas/Accounts/github(value))',
customFieldMask: 'Accounts',
})

const githubAccounts = mod.formatUserList(userList.data.users)
do {
const userList = await service.users.list({
customer: 'my_customer',
maxResults: 250,
projection: 'custom',
fields: 'users(customSchemas/Accounts/github(value)),nextPageToken',
customFieldMask: 'Accounts',
pageToken: pageToken,
})
pageToken = userList.data.nextPageToken
githubAccounts = new Set([...githubAccounts, ...formatUserList(userList.data.users)])
} while (pageToken != null)
return githubAccounts
}

// eslint-disable-next-line @typescript-eslint/explicit-module-boundary-types
export function formatUserList(users): Set<string> {
export function formatUserList(users: any[]): Set<string> {
return new Set(
users
.map((user) => user.customSchemas?.Accounts?.github?.map((account) => account.value?.toLowerCase()))
.map((user) =>
user.customSchemas?.Accounts?.github?.map((account: { value: string }) => account.value?.toLowerCase()),
)
.flat()
.filter(Boolean),
)
Expand Down