CASSANDRA-20920 Mutation journal replay #4392
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iamaleksey
reviewed
Sep 26, 2025
iamaleksey
reviewed
Sep 26, 2025
iamaleksey
reviewed
Sep 26, 2025
iamaleksey
reviewed
Sep 26, 2025
iamaleksey
reviewed
Sep 26, 2025
Improvements * clean up RecordPointer * cache last segment Implement mutation journal replay Persist clean/dirty state in metadata component Add mutation journal replay test, fix several issues, wire in journal into memtable Add bounce dtest, fix some more tests
iamaleksey
reviewed
Sep 26, 2025
iamaleksey
reviewed
Sep 26, 2025
src/java/org/apache/cassandra/replication/SegmentStateTracker.java
Outdated
Show resolved
Hide resolved
ifesdjeen
force-pushed
the
CASSANDRA-20919-mutation-journal-replay
branch
from
431bb91 to
3957151
Compare
ifesdjeen
force-pushed
the
CASSANDRA-20919-mutation-journal-replay
branch
from
3957151 to
f106fe6
Compare
ifesdjeen
changed the title
iamaleksey
reviewed
Sep 29, 2025
|
The tests could be extended slightly to verify that the offsets are recorded as witnessed by |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch introduces
SegmentStateTracker, which tracks Mutation Journal allocations and listens to Memtable->SSTable flushes.SegmentStateTrackerlogic is largely adapted from CommitLog (i.e. tracking dirty allocation upper bound, and clean/flushed min/max bounds, and checking their intersection to see if entire segment is flushed.MutationJournalnow tracks new allocations per segment (and, within a segment, per table), and listens to Memtable flushes, markingCommitLogPositionbounds reported by the flush as clean.MutationJournal#replayis added, and serves a purpose similar to CommitLog replay, albeit lacks some of its functionality, such as replay filter, for now (missing pieces documented inline). Only segments holding allocations that were not memtable->sstable flushed are considered for replay.CASSANDRA-20920 Mutation journal replay