update showPaginator #45
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Paginator is not hidden when style is inherited. Better to set display to 'none' explicitly.
added / to path. Otherwise, workerSrc not found if baseUrl does not end with /
anvithks
requested changes
Aug 31, 2023
There was a problem hiding this comment.
Thanks for the PR @robertwenink
Please check my comments. Will merge the PR once the results are confirmed.
| if(hidePaginator) return | ||
| paginator.style.display = 'block'; | ||
| if(hidePaginator) { | ||
| paginator.style.display = 'none'; |
Make the loading wrapper float left, such that the download button is not pushed down during loading but stays in its location.
|
Kudos, SonarCloud Quality Gate passed!
|
|
@robertwenink I haven't been able to get around to verifying this PR on my demo. I will try to spend sometime soon and merge this |
|
Confirmed that this fix works on my domain |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Paginator is not hidden when style is inherited. Better to set display to 'none' explicitly.