Changes related to supporting Pager Duty as a receiver #8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is for receivers:
SecretsProviderRegistry
per tenantSecretsProviderRegistry
has 1..n SecretProviders but only 1 provider of each type. AWSSecretsManagerProvider, InlineProvider are examples of provider. A registry can contain many providers but only one AWSSecretsManagerProvider and one InlineProvider (and one each of other types in the future)SecretProvider
is free to implement however but in this implementationAWSSecretsManagerProvider
maintains 1SecretsFetcher
per SecretARN. I chose to do it this way because each SecretARN's lifecycle can be different and theAWSSecretsManagerProvider
manages the lifecycle of all the fetchers. For example, if the same ARN is registered twice,AWSSecretsManagerProvider
will only create 1SecretsFetcher
*Corresponding Cortex Changes https://github.com/aws-observability/cortex-dev/commit/0278ebb20a6cf30090988e5d1a39dcff3a59f56d