POC - Persistence Test Kit for xunit v3 #7820
Conversation
| </PropertyGroup> | ||
|
|
||
| <ItemGroup> | ||
| <ProjectReference Include="..\..\contrib\testkits\Akka.TestKit.Xunit\Akka.TestKit.Xunit.csproj" /> |
There was a problem hiding this comment.
Pulling the reference in here brings in xunit v3
| using Actor; | ||
| using Akka.TestKit.Xunit; | ||
| using Configuration; | ||
| using Xunit; |
There was a problem hiding this comment.
The only changes to this file are the xunit references the rest is a full copy of the file. What theoretically could be done is creating a base class of the PersistenceTestKit in the base library and only have the constructors in the two xunit specific projects to minimise the copied code.
There was a problem hiding this comment.
There have been no other ways around duplicating the code that I can think of here without the references
| </ItemGroup> | ||
|
|
||
| <ItemGroup> | ||
| <ProjectReference Include="..\..\contrib\testkits\Akka.TestKit.Xunit2\Akka.TestKit.Xunit2.csproj" /> |
There was a problem hiding this comment.
I think this would be a breaking change someone could be referencing this project and only using the Akka.TestKit and not the Akka.Persistence.TestKit Not sure if it would be a problem but just calling that out
|
I wanted to see if I could get the Persistence tests all running using the new project and I was able to hack out quite a bit of data to get parts of the tests in a position to run with xunit3 and it has mostly worked. There are quite a few things that rely on some xunit v2 references but it does "prove" the new project added works. |
1 participant
I was working on a project and upgrading test kits and I came across the issue with the Persistence test kit being xunit 2 only
This is a proof of concept of how I think potentially can handle the other test kits similar to how the base testkit has been created. I have only tried this out on the Persistence test kit so far just to see if the approach is what should be used for the others.