Skip to content

Scope Code Dataset #658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 13 commits into
base: develop
Choose a base branch
from
Draft

Scope Code Dataset #658

wants to merge 13 commits into from

Conversation

@jwaspin
Copy link
Contributor

@jwaspin jwaspin commented Feb 26, 2024 •
edited
Loading

DO NOT MERGE - this PR is on hold until further notice, refer to comments below...

Closes #590

Changes

  • Deprecated code that overwrites "dataset" to "geographicDataset" (so the code that makes this change is removed by the PR, so that it remains "dataset" and is not modified to "geographicDataset"

@jwaspin jwaspin marked this pull request as ready for review April 9, 2024 16:50
@jwaspin jwaspin requested a review from hmaier-fws April 9, 2024 16:50
@jwaspin jwaspin marked this pull request as draft April 15, 2024 22:52
@jwaspin jwaspin marked this pull request as ready for review April 16, 2024 15:08
@hmaier-fws hmaier-fws added the deprecated Feature that is planned for removal and should no longer by used label May 6, 2024
@hmaier-fws
Copy link
Contributor

@jwaspin we can't merge this one. It will cause a fundamental change in how users document their data. I'm going to set this back to draft status and add some comments to #590.

@hmaier-fws hmaier-fws marked this pull request as draft May 6, 2024 22:03
@hmaier-fws hmaier-fws mentioned this pull request May 7, 2024
Open
jwaspin
jwaspin commented Mar 4, 2025
View reviewed changes
app/services/codelist.js
Comment on lines +72 to +78
// codeOverrides: computed('profile', function () {
// return {
// scope: {
// dataset: "geographicDataset"
// }
// }
// })
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note, this is the code being deprecated, if this is truly desired then the code should be removed, not just commented

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hmaier-fws hmaier-fws Awaiting requested review from hmaier-fws

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

deprecated Feature that is planned for removal and should no longer by used

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Errors with scope code "dataset"

3 participants

@jwaspin @hmaier-fws