fix: Update promo_div class name and improve robustness #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The old code would completely fail if the promo pop-up had changed class name. Now it should complete the other fixes as usual and just ignore the missing div. The others were already robust since they use an array, which would just be empty if it wasn't found. I also updated the selector to the new name of the promo div.
CantCode023
approved these changes
Dec 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old code would completely fail if the promo pop-up had changed class name. Now it should complete the other fixes as usual and just ignore the missing div. The others were already robust since they use an array, which would just be empty if it wasn't found.
I also updated the selector to the new name of the promo div.
I haven't tested the full extension, but copy-pasting the main function into the js console unblurs the page as it should now.