-
Notifications
You must be signed in to change notification settings - Fork 139
Add earnings rates endpoint to Payroll-Api-AU #752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
PETOSS-823 |
Thanks for raising an issue, a ticket has been created to track your request |
url: https://github.com/XeroAPI/Xero-OpenAPI/blob/master/LICENSE | ||
servers: | ||
- description: Xero Payroll AU API | ||
- description: Xero Payroll AU API (v1) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we need a new seperate server for our new endpoitns?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see here
xero-payroll-au.yaml
Outdated
- in: query | ||
name: page | ||
description: Page number which specifies the set of records to retrieve. By default the number of the records per set is 100. When page value is not a number or a negative number, by default, the first set of records is returned | ||
example: https://api.xero.com/payroll.xro/2.0/earningsRates?page=2 to get the second set of the records. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good catch yes!!
xero-payroll-au.yaml
Outdated
tags: | ||
- PayrollAu | ||
operationId: getEarningsRates | ||
x-hasPayrollUkProblem: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Its a vendor extension used for generation of the SDKs from the spec...specifically java sdk in this case 😀 Theres a list in xero-internal I'll send to you
xero-payroll-au.yaml
Outdated
tags: | ||
- PayrollAu | ||
operationId: createEarningsRate | ||
x-hasPayrollUkProblem: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here
xero-payroll-au.yaml
Outdated
operationId: getEarningsRate | ||
servers: | ||
- url: https://api.xero.com/payroll.xro/2.0 | ||
x-hasPayrollUkProblem: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also here
xero-payroll-au.yaml
Outdated
Pagination: | ||
properties: | ||
page: | ||
type: integer | ||
example: 1 | ||
pageSize: | ||
type: integer | ||
example: 10 | ||
pageCount: | ||
type: integer | ||
example: 1 | ||
itemCount: | ||
type: integer | ||
example: 2 | ||
Problem: | ||
description: The object returned for a bad request | ||
type: object | ||
properties: | ||
type: | ||
description: The type of error format | ||
type: string | ||
example: application/problem+json | ||
title: | ||
description: The type of the error | ||
type: string | ||
example: BadRequest | ||
status: | ||
description: The error status code | ||
type: string | ||
example: 400 | ||
detail: | ||
description: A description of the error | ||
type: string | ||
example: Validation error occurred. | ||
instance: | ||
type: string | ||
invalidFields: | ||
type: array | ||
items: | ||
$ref: '#/components/schemas/InvalidField' | ||
InvalidField: | ||
type: object | ||
properties: | ||
name: | ||
description: The name of the field that caused the error | ||
type: string | ||
example: isExemptFromSuper | ||
reason: | ||
description: The reason the error occurred | ||
type: string | ||
example: The property isExemptFromSuper is required. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yep they are part of the open api schema for the v2 endpoints
xero-payroll-au.yaml
Outdated
description: For allowances using RatePerUnit only, whether it contributes towards the overtime rate. | ||
type: boolean | ||
example: false | ||
EarningsRateObject: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
EarningsRateObject needs to be cleaned up thank you!
operationId: getEarningsRates | ||
x-hasPayrollUkProblem: true | ||
servers: | ||
- url: https://api.xero.com/payroll.xro/2.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rickyh5000 have left the server uri as is and only added the V2 server uri for the V2 endpoints... however if you think it would be easier to understand we can always put both server uris into the dropdown?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just think it might be a bit misleading but not sure how easy it is to put the V2 server uri into the dropdown
… for pagination query param, remove unnecessary object
type: boolean | ||
example: false | ||
AccrueLeave: | ||
description: Indicates that this earnings rate should affect accruing of leave. Only applicable if RateType is MULTIPLEOFORDINARYEARNINGSRATE |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
description: Indicates that this earnings rate should affect accruing of leave. Only applicable if RateType is MULTIPLEOFORDINARYEARNINGSRATE | |
description: Indicates that this earnings rate should affect accruing of leave. |
Not sure if we need that extra part here, this feels like more just a generic description and the Required if RateType is MultipleOfOrdinaryEarningsRate
is more for the POST only
Description
Release Notes
Screenshots (if appropriate):
Types of Changes