Add test to verify mount() correctly handles files (closes #503) #2564
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 @jnealey88 thank you for the test! It seems like this PR got intertwined with #2561 – would you mind removing the changes unrelated to |
adamziel
added
[Type] Enhancement
…ss#503) This test confirms that the mount() method properly creates a file node (not a directory) when mounting a file. The issue described in WordPress#503 appears to have been resolved in PR WordPress#2338 when file mounting support was added to NODEFS. The test explicitly checks: - That the mount point doesn't exist before mounting - That after mounting a file, isFile() returns true - That after mounting a file, isDir() returns false This ensures the behavior described in issue WordPress#503 is working correctly.
jnealey88
force-pushed
the
fix/mount-file-creates-directory-issue-503
branch
from
fe62613 to
076be88
Compare
|
@adamziel - My fault! Should be good to go now. |
|
Thank you so much @jnealey88! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #503
This PR adds a test to verify that the
mount()method correctly creates file nodes (not directories) when mounting files.Investigation Results
After investigating issue #503, it appears the bug described has already been resolved. The current implementation in
node-fs-mount.tscorrectly:FS.mkdirTree(dirname(vfsMountPoint))FS.mkdirTree(vfsMountPoint)This fix was likely implemented as part of PR #2338 ("File mounting in NODEFS").
Changes
mount.spec.tsthat verifies:isFile()returnstrueisDir()returnsfalseTest Plan
The new test case ensures this behavior remains correct and prevents regression. The test explicitly addresses the concern raised in issue #503.
Since the bug appears to be already fixed, this PR primarily serves to: