Skip to content

Get EntityStore directly from WikibaseRepo #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Get EntityStore directly from WikibaseRepo #11

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a4a1838
Update WikibaseRepo::getStore() calls
lucaswerkmeister Mar 30, 2021
b527d6e
Get EntityStore directly from WikibaseRepo
lucaswerkmeister Apr 9, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion maintenance/importEntities.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ private function newEntityIdListBuilderFactory() {

private function newEntityImporter() {
$entityImporterFactory = new EntityImporterFactory(
WikibaseRepo::getDefaultInstance()->getStore()->getEntityStore(),
WikibaseRepo::getEntityStore(),
wfGetLB(),
$this->logger,
$this->getConfig()->get( 'WBImportSourceApi' )
Expand Down
2 changes: 1 addition & 1 deletion tests/integration/ApiEntityLookupIntegrationTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ public function testGetEntity() {

private function getApiEntityLookup() {
$entityImporterFactory = new EntityImporterFactory(
WikibaseRepo::getDefaultInstance()->getStore()->getEntityStore(),
WikibaseRepo::getEntityStore(),
wfGetLB(),
$this->newLogger(),
'https://www.wikidata.org/w/api.php'
Expand Down
2 changes: 1 addition & 1 deletion tests/integration/EntityImporterFactoryTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ public function testGetApiEntityLookup() {

private function newEntityImporterFactory() {
return new EntityImporterFactory(
WikibaseRepo::getDefaultInstance()->getStore()->getEntityStore(),
WikibaseRepo::getEntityStore(),
wfGetLB(),
$this->newLogger(),
'https://www.wikidata.org/w/api.php'
Expand Down