Add min_ttl and max_ttl to the Host class and ttl to the ICMPReply class
#55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @joente, Thanks for this PR. Although I find the interest of the TTL limited (there have already been several requests on this subject), I will however think about it for future versions. With icmplib, I try to have a parity between the features available between IPv4 and IPv6. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The TTL properties are missing when preforming a ping (or async_ping)
Added a
min_ttlandmax_ttlproperty to theHostclass which is filled from a newttlproperty on theICMPReplyclass.In this version it only works for IPv4 which is enough most of the time although we could search for an implementation for IPv6 as well. (this version would return
0for both min- and max_ttl when using an IPv6 address.