-
Couldn't load subscription status.
- Fork 75
feat: Enable vitepress build #1133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
037ceae to
31934ec
Compare
8961b0d to
7a2ce4f
Compare
64066ac to
f3a5128
Compare
6afdfe1 to
36c75f1
Compare
0107968 to
af5446d
Compare
7d5eba8 to
8beda5d
Compare
c1e36b7 to
a934f2a
Compare
|
|
a934f2a to
c1e36b7
Compare
The CLI page must be generated via the |
d0c7ac3 to
5311640
Compare
My intention was to do the cleanup in the next step, but now I have fixed the formatting and links. |
Co-authored-by: Max Reichmann <91143102+maxreichmann@users.noreply.github.com>
packages/documentation/docs/pages/extensibility/ProjectShims.md
Outdated
Show resolved
Hide resolved
| </script> | ||
|
|
||
| <div style="margin: 1rem 0;"> | ||
| <VPButton class="no-decoration" text="📚 API Reference" href="https://ui5.github.io/cli/v4/api/"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
v4?
I wonder why we can't use relative links here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It' should be v5, indeed and I have adjusted it, but It used to be that way so far.
I was trying to just adjust the formatting and eventually something broken/wrong.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Going through the pages I noticed..
- the API reference links sometimes include
v4, sometimesv5(currently 404). I suggest usingstable. - nit: On "Migrate to v3", the caption formatting could be improved. Since, it's v3 it might not be relevant.
Thanks! The formatting should is fine now |

This change continues the efforts from #1132 and enhances it by enabling vitepress build of the documentation.
JIRA: CPOUI5FOUNDATION-899