Guard against nil properties, ensure that worker messages are for the current video, update osc #55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 7, 2020 13:02
…om workers that are for previous state versions (we may get messages from workers for the previous video after the video has changed).
|
This seems much more stable than any previous attempt. I did have one time where the OSC went away, but I wasn't connected to a terminal at the time so I couldn't get a traceback or anything. But this PR definitely improves the situation significantly, and I've noticed no problems with it, so I recommend merging. |
|
No more OSC crashes with these changes. |
blankname
force-pushed
the
nil-props
branch
2 times, most recently
from
a4372ad to
9770191
Compare
blankname
force-pushed
the
nil-props
branch
2 times, most recently
from
6b7ffe1 to
5d39be0
Compare
blankname
force-pushed
the
nil-props
branch
from
5d39be0 to
70d8943
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should be a more complete fix for the race condition issues in #54.