Skip to content

Conversation

@hierynomus
Copy link
Contributor

No description provided.

@hierynomus hierynomus requested a review from devpro as a code owner November 5, 2024 10:07
Copy link
Contributor

@devpro devpro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you make the related changes?

  • template files must follow conventions (no need for ai-model prefix)
  • ai-model Helm chart name is too general, needs to be more explicit/specific
  • README.md file in Helm chart (at least to explain what is the purpose of the chart)
  • use more variables in Helm charts
  • Mackroservices is mentioned in Helm chart file but what is Mackroservices?

@hierynomus
Copy link
Contributor Author

@devpro This is purely a demo workload that is autogenerated. It doesn't contain any working code, just a mocked up service for observability purposes. It's part of the demo flow that we need to demo on rancher day

@devpro devpro changed the title Prime Add AI model demo Helm chart and Rancher prime installation script Nov 5, 2024
Signed-off-by: Jeroen van Erp <jeroen.vanerp@suse.com>
Signed-off-by: Jeroen van Erp <jeroen.vanerp@suse.com>
Signed-off-by: Jeroen van Erp <jeroen.vanerp@suse.com>
Signed-off-by: Jeroen van Erp <jeroen.vanerp@suse.com>
Signed-off-by: Jeroen van Erp <jeroen.vanerp@suse.com>
Signed-off-by: Jeroen van Erp <jeroen.vanerp@suse.com>
Signed-off-by: Jeroen van Erp <jeroen.vanerp@suse.com>
Signed-off-by: Jeroen van Erp <jeroen.vanerp@suse.com>
hierynomus and others added 16 commits November 7, 2024 12:28
Signed-off-by: Jeroen van Erp <jeroen.vanerp@suse.com>
Signed-off-by: Jeroen van Erp <jeroen.vanerp@suse.com>
Signed-off-by: Jeroen van Erp <jeroen.vanerp@suse.com>
Signed-off-by: Jeroen van Erp <jeroen.vanerp@suse.com>
Signed-off-by: Jeroen van Erp <jeroen.vanerp@suse.com>
Signed-off-by: Jeroen van Erp <jeroen.vanerp@suse.com>
Signed-off-by: Jeroen van Erp <jeroen.vanerp@suse.com>
Signed-off-by: Jeroen van Erp <jeroen.vanerp@suse.com>
Signed-off-by: Jeroen van Erp <jeroen.vanerp@suse.com>
Signed-off-by: Jeroen van Erp <jeroen.vanerp@suse.com>
Signed-off-by: Jeroen van Erp <jeroen.vanerp@suse.com>
Signed-off-by: Jeroen van Erp <jeroen.vanerp@suse.com>
Signed-off-by: Jeroen van Erp <jeroen.vanerp@suse.com>
rmahique and others added 20 commits January 31, 2025 20:10
Signed-off-by: Jeroen van Erp <jeroen.vanerp@suse.com>
Signed-off-by: Jeroen van Erp <jeroen.vanerp@suse.com>
Signed-off-by: Jeroen van Erp <jeroen.vanerp@suse.com>
Signed-off-by: Jeroen van Erp <jeroen.vanerp@suse.com>
Signed-off-by: Jeroen van Erp <jeroen.vanerp@suse.com>
Signed-off-by: Jeroen van Erp <jeroen.vanerp@suse.com>
add functions to retrieve kubernetes and rancher versions
Signed-off-by: Jeroen van Erp <jeroen.vanerp@suse.com>
Signed-off-by: Jeroen van Erp <jeroen.vanerp@suse.com>
Signed-off-by: Jeroen van Erp <jeroen.vanerp@suse.com>
Signed-off-by: Jeroen van Erp <jeroen.vanerp@suse.com>
Signed-off-by: Jeroen van Erp <jeroen.vanerp@suse.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants