Merge Kristo's work #36
Conversation
| flux_star_interp[om.star.log_λ .< minimum(om.metadata[:fixed_vectors]["log_λ"])] .= 1 | ||
| flux_star_interp[om.star.log_λ .> maximum(om.metadata[:fixed_vectors]["log_λ"])] .= 1 |
There was a problem hiding this comment.
@kment Could you add a comment about the logic here?
I'm wondering if setting these pixels to 1 might affect the predictions between the minimum and maximum.
| flux_star_interp[oms[1,1].star.log_λ .< minimum(fixed_vectors["log_λ"])] .= 1 | ||
| flux_star_interp[oms[1,1].star.log_λ .> maximum(fixed_vectors["log_λ"])] .= 1 | ||
| oms[1,1].star.lm.μ[:] = flux_star_interp | ||
| flux_star .*= flux_star_interp |
There was a problem hiding this comment.
@kment Was flux_star initialized to 1? If not, please document why you're multiplying here.
| using FITSIO | ||
| using DataInterpolations | ||
|
|
||
| teldir = "/home/kment/RV/telluric" # Directory containing telluric model spectra |
There was a problem hiding this comment.
@kment Please replace this path with something more general. We could create a data directory and then we can access it with joinpath(pkgdir(StellarSpectraObservationFitting, "data"), filename)
There was a problem hiding this comment.
If the files are small, we can just stick them in this repository. If they're large then we can add a script in 'deps/build.jl' that downloads the files into the data subdirectory. It could be from a separate GitHub repository (maybe TelluricModels or SSOFTelluricModels?) or a Zenodo url.
There was a problem hiding this comment.
Another option is to take the directory from a LocalPreferences.toml file in the same directory as the Project.toml.
No description provided.