Extend Grouped GEMM with MultiD (Single & Double Shared Memory) feature to use persistent kernel option #2933
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AviralGoelAMD
requested review from
illsilin,
carlushuang,
qianfengz,
aosewski,
poyenc,
geyyer,
bartekxk,
andriy-ca,
afagaj,
asleepzzz,
ThomasNing,
coderfeli,
aska-0096,
cgmillette,
shumway,
vidyasagar-amd,
ddembeckAMD,
a team and
tenpercent
as code owners
spolifroni-amd
requested changes
Sep 26, 2025
…emm and multi_d_gemm feature
…emm and multi_d_gemm feature
AviralGoelAMD
force-pushed
the
aviralgoel/grouped_gemm_persistant_multid
branch
from
11d05e5 to
8c58908
Compare
amd-khushbu
reviewed
Sep 26, 2025
example/ck_tile/17_grouped_gemm/run_grouped_gemm_multi_d_example.inc
Outdated
Show resolved
Hide resolved
7 tasks
AviralGoelAMD
changed the title
|
CI passed |
ThomasNing
approved these changes
Sep 29, 2025
illsilin
approved these changes
Sep 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
In #2923, We introduce MultiD feature into grouped_gemm example. The feature was limited to grouped_gemm using non-persistent kernel for both single and double shared memory. In this PR, we extend the feature with option to use persistant kernel. This option can be triggered from GemmConfig struct in .hpp
This PR requires #2923 to merged into develop
Checklist
Please put an
xinto the boxes that apply. You can also fill these out after creating the PR. If you're not sure, please don't hesitate to ask.clang-formaton all changed filesYes, if Integrate Multi D GEMMs into Grouped GEMMs along with unit tests #2923 is merged.