Skip to content

Conversation

bartekxk
Copy link
Contributor

Proposed changes

Shard grouped conv bwd data instances to improve compilation time

Checklist

Please put an x into the boxes that apply. You can also fill these out after creating the PR. If you're not sure, please don't hesitate to ask.

  • I have added tests relevant to the introduced functionality, and the unit tests are passing locally
  • I have added the test to REGRESSION_TESTS list defined at the top of CMakeLists.txt in tests/CMakeLists.txt, IF the test takes more than 30 seconds to run.
  • I have added inline documentation which enables the maintainers with understanding the motivation
  • I have removed the stale documentation which is no longer relevant after this pull request
  • (If this change is user-facing) I have added release notes which provide the end users with a brief summary of the improvement from this pull request
  • I have run clang-format on all changed files
  • Any dependent changes have been merged

Discussion

If this is a relatively large or complex change, feel free to start a discussion by explaining why you chose the solution you did and what alternatives you considered

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request implements sharding for grouped convolution backward data instances to improve compilation time. The changes transform monolithic instance files into sharded templates using a modulo-based filtering approach.

  • Transforms function-based instance generation to template-based sharded instantiation
  • Introduces sharding with different numbers of shards for various data types and configurations
  • Refactors CMakeLists.txt to use the new sharding infrastructure

Reviewed Changes

Copilot reviewed 72 out of 72 changed files in this pull request and generated no comments.

File Description
CMakeLists.txt files Replace hardcoded file lists with sharded instance generation
Instance template files (.in) Convert functions to templated sharded functions with modulo filtering
Header files (.inc/.hpp) Update function declarations to match renamed functions
Source files (.cpp) Fix function name consistency in scale and bilinear variants

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Base automatically changed from barkocot/bwd-data-custom-transform to develop September 29, 2025 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant