-
-
Notifications
You must be signed in to change notification settings - Fork 481
refactor: ♻️ update deprecated usage to use typing.deprecated
#2828
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
refactor: ♻️ update deprecated usage to use typing.deprecated
#2828
Conversation
Signed-off-by: Paillat <paillat@pycord.dev>
This pull request is in the In review step of the Pycord workflow. Waiting for review from these teams:
Waiting on these users to move the PR forward: @Paillat-dev, @ChickenDevs, @plun1331. |
Signed-off-by: Paillat <paillat@pycord.dev>
b55c125
to
82659b2
Compare
@Pycord-Development/library-contributors
Ref: https://discord.com/channels/881207955029110855/903819190274764800/1412100052780056627 |
Summary
Fixes #1917
Redo of #2655
The previous version of the PR did not work correctly with type checkers, this one does, with the compromise of needing to use the
@deprecated(deprecated_message(...))
syntax. This allows for type checkers to mark methods as deprecated and do some kind of strike trough like shown below:Information
examples, ...).
Checklist
type: ignore
comments were used, a comment is also left explaining why.