Skip to content

Conversation

Paillat-dev
Copy link
Member

Summary

Fixes #1917
Redo of #2655

The previous version of the PR did not work correctly with type checkers, this one does, with the compromise of needing to use the @deprecated(deprecated_message(...)) syntax. This allows for type checkers to mark methods as deprecated and do some kind of strike trough like shown below:

image

Information

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting,
    examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.
  • I have updated the changelog to include these changes.

Signed-off-by: Paillat <paillat@pycord.dev>
@pullapprove4 pullapprove4 bot requested a review from plun1331 August 6, 2025 08:38
Copy link

pullapprove4 bot commented Aug 6, 2025

This pull request is in the In review step of the Pycord workflow.

Waiting for review from these teams:

Waiting on these users to move the PR forward: @Paillat-dev, @ChickenDevs, @plun1331.

@Paillat-dev Paillat-dev requested a review from a team as a code owner August 28, 2025 21:58
@Lulalaby Lulalaby removed the request for review from ChickenDevs August 28, 2025 23:38
@Lulalaby Lulalaby force-pushed the master branch 2 times, most recently from b55c125 to 82659b2 Compare August 30, 2025 21:10
@Lulalaby Lulalaby removed the on hold label Aug 30, 2025
@Lulalaby
Copy link
Member

Lulalaby commented Sep 1, 2025

@Pycord-Development/library-contributors

I need some input, specifically we should probably ditch the strict formatting for deprecation messages entirely to stay in confomrity with python syle guides so idk pls give opinions

Ref: https://discord.com/channels/881207955029110855/903819190274764800/1412100052780056627
Discussion here or https://discord.com/channels/881207955029110855/881735314987708456

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update utils.deprecated to use PEP 702
2 participants