Skip to content

feat(loop): add optional overlap support to allow concurrent loop executions #2771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 50 commits into
base: master
Choose a base branch
from
Open

feat(loop): add optional overlap support to allow concurrent loop executions #2771

wants to merge 50 commits into from

Conversation

Lumabots
Copy link
Contributor

@Lumabots Lumabots commented Apr 30, 2025 •
edited by Lulalaby
Loading

No description provided.

Lumabots and others added 10 commits April 18, 2025 16:44
@Lumabots
🆕 feat(loop): add optional overlap support to allow concurrent loop e…
9dc617d 
…xecutions

Added a new overlap parameter to the loop decorator and Loop class to control whether loop iterations can run concurrently. When set to True, the next iteration will not wait for the previous one to finish, allowing overlapping executions—useful for long-running tasks that should not delay subsequent runs. Defaults to False to preserve current behavior.

Signed-off-by: Lumouille <144063653+Lumabots@users.noreply.github.com>
@pre-commit-ci
style(pre-commit): auto fixes from pre-commit.com hooks
bfda3aa
@Lumabots
Update CHANGELOG.md
8dc95c4 
Signed-off-by: Lumouille <144063653+Lumabots@users.noreply.github.com>
@pre-commit-ci
style(pre-commit): auto fixes from pre-commit.com hooks
7dbf3a0
@Lumabots
Update __init__.py
1f1ef8a 
Signed-off-by: Lumouille <144063653+Lumabots@users.noreply.github.com>
@Lumabots
fix- TypeError: Loop.__init__() missing 1 required positional argumen…
570ae99 
…t: 'overlap'

Signed-off-by: Lumouille <144063653+Lumabots@users.noreply.github.com>
@Lumabots
fix cancellation using overlap=true
c8f3bb4 
Signed-off-by: Lumouille <144063653+Lumabots@users.noreply.github.com>
@Lumabots
fix
463a249 
Exception in callback Future.set_result(True)
handle: <TimerHandle when=203424.768941542 Future.set_result(True)>
Traceback (most recent call last):
  File "/usr/local/lib/python3.11/asyncio/events.py", line 84, in _run
    self._context.run(self._callback, *self._args)
asyncio.exceptions.InvalidStateError: invalid state


Signed-off-by: Lumouille <144063653+Lumabots@users.noreply.github.com>
@Lumabots
fix identation
26a8ff1 
Signed-off-by: Lumouille <144063653+Lumabots@users.noreply.github.com>
@Lumabots
Merge branch 'master' into patch-2
253c67c
@Lumabots Lumabots requested a review from a team as a code owner April 30, 2025 19:30
@pullapprove4 pullapprove4 bot requested a review from Dorukyum April 30, 2025 19:30
@pullapprove4 pullapprove4 bot requested a review from Lulalaby April 30, 2025 19:30
@Lumabots
Copy link
Contributor Author

sorry i renamed the branch and it deleted the other one

@Lumabots Lumabots changed the title Overlap feat(loop): add optional overlap support to allow concurrent loop executions Apr 30, 2025
@plun1331 plun1331 mentioned this pull request May 1, 2025
Closed
9 tasks
plun1331
plun1331 previously requested changes May 1, 2025
View reviewed changes
Copy link
Member

@plun1331 plun1331 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably add an additional parameter for limiting the number of active tasks

Lumabots and others added 2 commits May 1, 2025 11:17
@Lumabots @plun1331
Update CHANGELOG.md
7e4fd6a 
Co-authored-by: plun1331 <plun1331@gmail.com>
Signed-off-by: Lumouille <144063653+Lumabots@users.noreply.github.com>
@Lumabots @plun1331
Update discord/ext/tasks/__init__.py
1562e64 
Co-authored-by: plun1331 <plun1331@gmail.com>
Signed-off-by: Lumouille <144063653+Lumabots@users.noreply.github.com>
@Lumabots
Copy link
Contributor Author

Lumabots commented May 1, 2025 •
edited
Loading

We should probably add an additional parameter for limiting the number of active tasks

maybe:
def init(self, ..., overlap: bool | int = True):

If overlap is:

True: allow overlapping tasks with no limit (default).

False: do not allow overlapping (wait for task to finish).

An int: allow overlapping up to n concurrent tasks.

Lumabots and others added 6 commits May 1, 2025 11:32
@Lumabots
Update __init__.py
734ce8a 
add name for the tasks

Signed-off-by: Lumouille <144063653+Lumabots@users.noreply.github.com>
@pre-commit-ci
style(pre-commit): auto fixes from pre-commit.com hooks
fc137dd
@Lumabots
Update __init__.py
0898f82 
Signed-off-by: Lumouille <144063653+Lumabots@users.noreply.github.com>
@Lumabots
Update __init__.py
209232f 
Signed-off-by: Lumouille <144063653+Lumabots@users.noreply.github.com>
@Lumabots
Update __init__.py
f24682a 
Signed-off-by: Lumouille <144063653+Lumabots@users.noreply.github.com>
@pre-commit-ci
style(pre-commit): auto fixes from pre-commit.com hooks
49bf2b7
@Lumabots
Merge branch 'master' into overlap
bee78d3 
Signed-off-by: Lumouille <144063653+Lumabots@users.noreply.github.com>
@Lumabots
Copy link
Contributor Author

Lumabots commented Aug 2, 2025 •
edited
Loading

fixed

Lumabots added 2 commits August 2, 2025 13:35
@Lumabots
Merge branch 'master' into overlap
b1cf42c 
Signed-off-by: Lumouille <144063653+Lumabots@users.noreply.github.com>
@Lumabots
Merge branch 'master' into overlap
af62dc5
@Lumabots Lumabots requested a review from a team as a code owner August 30, 2025 13:16
@Lumabots
Merge branch 'master' into overlap
6546270 
Signed-off-by: Lumouille <144063653+Lumabots@users.noreply.github.com>
@Lulalaby Lulalaby requested a review from Copilot August 30, 2025 15:18
@Lulalaby Lulalaby dismissed stale reviews from JustaSqu1d and plun1331 August 30, 2025 15:19

x

Copilot
Copilot AI reviewed Aug 30, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds optional overlap support to the loop decorator and Loop class to allow concurrent executions of loop iterations. Instead of waiting for each iteration to complete before starting the next one, users can now enable overlapping executions.

Key changes:

  • Adds overlap parameter that accepts False (default), True, or an integer for controlled concurrency
  • Uses asyncio tasks and semaphores to manage concurrent executions
  • Adds proper cleanup of running tasks when the loop is cancelled

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

File Description
discord/ext/tasks/init.py Implements overlap functionality with task management, semaphore controls, and concurrent execution logic
CHANGELOG.md Documents the new overlap feature in version 2.7

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@Lulalaby Lulalaby added this to the v2.7 milestone Aug 30, 2025
@github-project-automation github-project-automation bot moved this to In Progress in Pycord Releases Aug 30, 2025
@Lulalaby Lulalaby added feature Implements a feature on hold labels Aug 30, 2025
@Lulalaby Lulalaby force-pushed the master branch 2 times, most recently from b55c125 to 82659b2 Compare August 30, 2025 21:10
@Lulalaby Lulalaby removed the on hold label Aug 30, 2025
Lulalaby
Lulalaby reviewed Aug 31, 2025
View reviewed changes
Copy link
Member

@Lulalaby Lulalaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could that potentially clutch with #2645?

DA-344
DA-344 requested changes Aug 31, 2025
View reviewed changes
@Lumabots @DA-344
Update discord/ext/tasks/__init__.py
2e4895c 
Co-authored-by: DA344 <108473820+DA-344@users.noreply.github.com>
Signed-off-by: Lumouille <144063653+Lumabots@users.noreply.github.com>
@Lumabots Lumabots requested a review from a team as a code owner August 31, 2025 20:59
@Lumabots
Copy link
Contributor Author

Lumabots commented Sep 7, 2025

Could that potentially clutch with #2645?

Not anymore

@Lumabots Lumabots mentioned this pull request Sep 8, 2025
Open
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lulalaby Lulalaby Lulalaby left review comments

Copilot code review Copilot Copilot left review comments

@DA-344 DA-344 DA-344 requested changes

@Dorukyum Dorukyum Awaiting requested review from Dorukyum

@plun1331 plun1331 Awaiting requested review from plun1331

@JustaSqu1d JustaSqu1d Awaiting requested review from JustaSqu1d

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
feature Implements a feature PA: All Contributors pending PA: Maintainers pending
Projects
Pycord Releases
Status: In Progress
Milestone
v2.7
Development

Successfully merging this pull request may close these issues.
5 participants
@Lumabots @plun1331 @Lulalaby @JustaSqu1d @DA-344