Skip to content

Conversation

wgnvrd
Copy link
Contributor

@wgnvrd wgnvrd commented Jun 21, 2020

resolves #305

What I did

if the selected tree is a heritage tree, then the link to nominate the tree will hide itself.

@emillipede
Copy link
Collaborator

thank you @isabelle-wagenvoord !

please take another look. when I test it, the nomination section still appears in the sidebar for heritage trees. the regular (placeholder) text on the landing page sidebar's also disappeared.

to find a heritage tree, you can use the "SM heritage" button. the screenshot is of tree id=10934061

Screen Shot 2020-06-21 at 3 05 25 PM
Screen Shot 2020-06-21 at 3 06 27 PM

@wgnvrd wgnvrd force-pushed the hide-heritage-nomination-section branch from c993f98 to 9475a2d Compare June 22, 2020 03:03
@wgnvrd
Copy link
Contributor Author

wgnvrd commented Jun 22, 2020

Ah, my bad! Hopefully it should work now.

@emillipede
Copy link
Collaborator

thanks @isabelle-wagenvoord

can you please share a screenshot of how it looks when you look at the branch? when I open the index.html file, it looks the same as it did before. thank you again!

@emillipede
Copy link
Collaborator

@isabelle-wagenvoord I forgot to ask about this PR, I'm sorry! when you test it on your end, do you see the same issues I notice?

@wgnvrd
Copy link
Contributor Author

wgnvrd commented Jul 4, 2020

Ah my bad @emillipede. I think I forgot to add my changes before committing them 😅. Does it work now?

@emillipede
Copy link
Collaborator

thanks for the update @isabelle-wagenvoord ! the sidebar placeholder text is visible again when I locally open this branch, but the heritage section of the sidebar still shows up for existing heritage trees

when you test the branch, does it look different to you? please let me know. I'm sorry, I don't know what's wrong :(

?id=10915056
Screen Shot 2020-07-05 at 9 44 42 PM

@emillipede emillipede marked this pull request as draft August 8, 2020 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants