better support for CentOS; reboot if installer was unable to reload kernel module #27
Conversation
|
Thanks for your additions! I'll be testing the PR shortly on other OS flavors... |
|
|
||
| - name: Check if VBoxGuest additions ISO is mounted | ||
| shell: mount -l 2>/dev/null|awk '/VBOXADDITIONS/{print $3}' | ||
| shell: mount -l 2>/dev/null|awk '/VBox_GAs/{print $3}' |
There was a problem hiding this comment.
This doesn't seem OS-independent. There should be a nicer way of checking whether it's mounted - the current function is bit clunky
There was a problem hiding this comment.
Ouch, that's not about OS. Looks like VirtualBox ISO volume name changed. And yes, mount detection fails for me a lot, too.
For both Debian and RPM distributions I have:
$ iso-info /usr/share/virtualbox/VBoxGuestAdditions.iso | grep '^Volume'
Volume : VBox_GAs_6.1.18
There was a problem hiding this comment.
Thanks for that info, that helps. I'll try to find a cleaner way to detect a mounted disk: Maybe just probing for the file/binary?
| state: present | ||
| when: kernel is defined and kernel.stdout is defined | ||
| - name: Get running kernel version | ||
| shell: "uname -r" |
There was a problem hiding this comment.
When no output redirection is necessary, it's safer to use the command module instead of the shell module.
Differences by OS family simplified and clarified. Role didn't work for me on CentOS as-is.
Kernel headers packages are removed quickly, so installation may fail if kernel is not updated. Added flag for it.
Detect if VM is still running old version of module and reboot.