Delete partial for PlatformSample #7874
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This partial is used on samples that use the PlatformSample, that used to be Windows only, but not anymore (I run a few on Mac). It also mentions that the tools are not necessary to run the sample, which is not accurate, as all the samples that reference it are samples that make use of ServiceControl or ServicePulse
DavidBoike
approved these changes
Oct 20, 2025
|
I believe what it was trying to say was that you don't need to install ServiceControl/ServicePulse separately, since the sample bundles a portable version of them that will get launched with the sample |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This partial is used on samples that use the PlatformSample, that used to be Windows only, but not anymore (I run a few on Mac). It also mentions that the tools are not necessary to run the sample, which is not accurate, as all the samples that reference it are samples that make use of ServiceControl or ServicePulse