Add Confidential tab #652
Open
Add Confidential tab #652
+13,284
−990
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@SocketSecurity ignore npm/prettier@3.6.2 |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
@SocketSecurity ignore npm/@fhevm/hardhat-plugin@0.0.1-6 |
Not sure if we can make AI description more clear as it already mention confidential + erc-20 Also wondering in tab using "confidential" vs "Zama" ? |
CoveMB
reviewed
Sep 24, 2025
packages/ui/import_map.json
Outdated
| "openai": "https://esm.sh/openai@5.13.1" | ||
| "openai": "https://esm.sh/openai@5.13.1", | ||
| "jszip": "https://esm.sh/jszip@3.6.0", | ||
| "@openzeppelin/wizard": "../../node_modules/@openzeppelin/wizard/dist/", |
There was a problem hiding this comment.
are those wizard import needed? (could we import from "../core.."?
There was a problem hiding this comment.
These are needed because there's cross-package imports between the Solidity and Confidential core packages, some of which are used for the types in the AI function definitions. Simplified to use ../core
ericglau
added a commit
to ericglau/contracts-wizard
that referenced
this pull request
Sep 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a Confidential tab that implements a confidential fungible token, using OpenZeppelin Confidential Contracts.
Includes:
@openzeppelin/wizard-confidentialpackage, UI, AI assistant, MCP tools.