pdftopdf: Backport 'pagesize_requested' field in ProcessingParameters struct #606
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eters struct This commit backports from the master branch the implementation of the 'pagesize_requested' field in the parameters for pdftopdf processing. Signed-off-by: Sergio Gómez <sergio.g.delreal@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are issues like #481, #526 and #583, where a regression is found in the pagesize handling due to the change in the defaults for print scaling.
The suggested solution is to pass the option
print-scaling=noneto the filter, but this only works for the master branch and not the 1.x branch, because the master branch introduced thepagesize_requestedin the parameters structure, changing the logic inside theprocessPDFTOPDF()function. This patch backports that logic, which seems to be the only relevant difference between the master and 1.x branches, and making the suggested solution work correctly.