Skip to content

Conversation

@amanda-wein
Copy link
Contributor

Summary of the discussion

Updated metadata for DALIA #254

Type of change (CHANGELOG.md)

Updated

  • Metadata updated for course 04

Workflow checklist

Automation

Closes #

PR-Assignee

Reviewer

  • 🐙 Follow the Reviewer Guidelines
  • 🐙 Provided feedback and show sufficient appreciation for the work done

@amanda-wein amanda-wein requested review from Ludee and han-f October 15, 2025 12:59
- Contact: oedb@oeko.de
- License: [CC BY 4.0](https://creativecommons.org/licenses/by/4.0/deed.en)
- Attribution: Öko-Institut (2022): Upload - Contribute data to the OEP.
- Attribution: Öko-Institut (2023): Upload and Publish - Contribute data to the OEP.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should stay as 2022?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wasn't sure, looking back through the change history for the file the oldest date I saw was in 2023 (I used that for the publication date in the metadata). Do we have a 2022 publication date for this one recorded somewhere?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah ok, then it might have been a typo. Thanks for sifting through. I can then approve.

han-f
han-f previously requested changes Oct 15, 2025
Copy link
Contributor

@han-f han-f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a minor comment.

@han-f han-f dismissed their stale review October 15, 2025 13:05

Comment was resolved

@Ludee Ludee changed the title Course 04 - Feature 254 dalia metadata Course 04 - Feature 254 dalia metadata #254 Oct 15, 2025
Copy link
Member

@Ludee Ludee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with suggestions

Co-authored-by: Ludwig Hülk <ludwig.huelk@rl-institut.de>
@vismayajochem vismayajochem mentioned this pull request Oct 21, 2025
5 tasks
@vismayajochem vismayajochem merged commit a91c59e into production Oct 22, 2025
@vismayajochem
Copy link
Contributor

Everything looks good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants