test(FileClientImpl): add isDeleted unit tests #182
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Agaba Derrick <agabaderrick18@gmail.com>#
Agaba-derrick
force-pushed
the
test/fileclientimpl-isdeleted
branch
from
fdb17b6 to
8d94980
Compare
|
@Ndacyayisenga-droid please review ! |
hendrikebbers
requested changes
May 30, 2025
| void testIsDeletedReturnsTrueForDeletedFile() throws HieroException { | ||
| final FileId fileId = FileId.fromString("1.2.3"); | ||
| final FileInfoResponse fileInfoResponse = Mockito.mock(FileInfoResponse.class); | ||
| when(protocolLayerClient.executeFileInfoQuery(any(FileInfoRequest.class))) |
There was a problem hiding this comment.
You do way to much mocking to create really reasonable tests. I assume I should some documentation how to create good tests for this project to make it more easy. For for not approving your work :(
There was a problem hiding this comment.
hey @hendrikebbers Apologies for the late reply I can resolve this using real objects
Signed-off-by: Agaba Derrick <agabaderrick18@gmail.com>
|
@hendrikebbers is this better ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FileClientImpl.isDeleted() Tests
Summary
Test Coverage
Core functionality
truefor deleted filesfalsefor active filesError handling
FileIdinput (throwsNullPointerException)HieroException)Integration verification
FileInfoRequestconstructionFileInfoResponsehandlingIssue
Closes #104