-
Notifications
You must be signed in to change notification settings - Fork 0
Version2 launched #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: version1
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Launching the interactive V2.0 of the Arduino digital clock with manual time setting, advanced alarm controls, and comprehensive documentation enhancements.
- Added
DigitalClockV2.ino
sketch featuring 4-button interface, smart alarm logic, and professional UX. - Overhauled
README.md
with step-by-step guides, cost breakdowns, updated diagrams, and a new project structure. - Removed the legacy
DigitalClock.ino
file to fully migrate to the V2.0 codebase.
Reviewed Changes
Copilot reviewed 3 out of 5 changed files in this pull request and generated 1 comment.
File | Description |
---|---|
README.md | Expanded documentation, added usage guides, diagrams, and updated project structure |
DigitalClock/DigitalClockV2.ino | New interactive clock implementation with button controls and advanced alarm features |
DigitalClock/DigitalClock.ino | Removed legacy V1 sketch |
Comments suppressed due to low confidence (2)
README.md:139
- The software setup section's code fences seem unbalanced here. Ensure the opening and closing ```bash fences correctly wrap the repository commands.
```bash
README.md:217
- The project structure is listed twice in the README, which can confuse readers. Remove the outdated file tree or consolidate it into a single accurate diagram.
Digital-Clock-with-Arduino-Uno/
if (digitalRead(btnIncMin) == LOW) { | ||
minute = (minute + 1) % 60; | ||
if (minute == 0) hour = (hour + 1) % 24; | ||
delay(200); | ||
} | ||
|
||
// -1 second | ||
if (digitalRead(btnDecSec) == LOW) { |
Copilot
AI
Jul 17, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using delay(200)
for button debouncing blocks the main loop and may cause missed time updates or button presses. Consider switching to a non-blocking debounce implementation using timestamps.
if (digitalRead(btnIncMin) == LOW) { | |
minute = (minute + 1) % 60; | |
if (minute == 0) hour = (hour + 1) % 24; | |
delay(200); | |
} | |
// -1 second | |
if (digitalRead(btnDecSec) == LOW) { | |
static unsigned long lastIncMinPress = 0; | |
if (digitalRead(btnIncMin) == LOW && now - lastIncMinPress >= 200) { | |
lastIncMinPress = now; | |
minute = (minute + 1) % 60; | |
if (minute == 0) hour = (hour + 1) % 24; | |
} | |
// -1 second | |
static unsigned long lastDecSecPress = 0; | |
if (digitalRead(btnDecSec) == LOW && now - lastDecSecPress >= 200) { | |
lastDecSecPress = now; |
Copilot uses AI. Check for mistakes.
🚀 What's Being Added:
Core Files:
DigitalClock/DigitalClockV2.ino
- The enhanced interactive codeREADME.md
- Professional documentation optimized for stars/viewsDependencies/LiquidCrystal_I2C-1.1.3.zip
- Version history and improvementsDocumentation:
Educational Resources: