Runtime genesis ledger: fail if ledger is too shallow #17726
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glyh
added
the
enhancement
|
Has this error been seen in practice at all? Just out of curiosity. |
cjjdespres
reviewed
Sep 10, 2025
| @@ -126,6 +126,10 @@ let main ~(constraint_constants : Genesis_constants.Constraint_constants.t) | |||
| let%bind accounts, staking_accounts_opt, next_accounts_opt = | |||
| load_config_exn config_file | |||
| in | |||
| if List.length accounts > 1 lsl constraint_constants.ledger_depth then | |||
There was a problem hiding this comment.
It might be worth adding a ledger_capacity or max_address method at some point, just to formalize the fact that a ledger can hold at most 2^depth accounts.
There's code in src/lib/merkle_address/merkle_address.ml that also does this check:
let of_int_exn ~ledger_depth index =
if Int.(index >= 1 lsl ledger_depth) then failwith "Index is too large"But nothing dedicated to this value specifically.
There was a problem hiding this comment.
Yes, but it's not obvious why we're running into this error in this context.
I run into this when using a wrong profile on this executable. It's kinda silly yes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a helpful error message, telling user they might be using a wrong build profile if situation occurs.