fix: variable handling and command execution in deployment script #17708
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explain your changes:
This update resolves issues with variable handling and command execution in the deployment script. Variables are now properly quoted to handle empty values and spaces, single quotes were replaced with double quotes for correct interpolation (
$SIGNED
,$PACKAGE
,$REPO
,$CHANNEL
), parentheses aroundwget
were removed to prevent a subshell from losing the GPG key, and quotes inside$SCRIPT
were escaped to ensure commands execute correctly indocker run
.Explain how you tested your changes:
The deployment script was executed in a controlled environment with various test cases, including empty and spaced variable values. Verified that
$SIGNED
,$PACKAGE
,$REPO
, and$CHANNEL
are correctly interpolated, GPG keys are preserved, and theecho "deb ..."
commands work as expected inside Docker containers.Checklist:
Dependency versions are unchanged
Modified the current draft of release notes with details on what is completed or incomplete within this project
Document code purpose, how to use it
Tests were added for the new behavior
All tests pass (CI will check this if you didn't)
Serialized types are in stable-versioned modules
Does this close issues? List them