Genesis Ledger: remove ability to create a new gensis ledger #17661
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
!ci-build-me |
glyh
force-pushed
the
lyh/remove-genesis-ledger-new
branch
from
2563b29 to
7f2a3af
Compare
|
!ci-build-me |
glyh
commented
Aug 22, 2025
| | `New -> | ||
| lazy | ||
| ( `Root | ||
| (Ledger.Root.create_temporary |
There was a problem hiding this comment.
We could probably remove Ledger.Root.create_temporary later as well, it doesn't seem like we need it in real code. It's only used in tests.
glyh
added
the
enhancement
|
Looks like ephemeral ledger should've been a mask, but we're set batching the underlying null ledger for some reason. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It doesn't make sense to me to create a new genesis ledger backed by a temp folder. Real use case should be covered by either
EphemeralorPath _Checking the code more closely, there's no way to retrieve the path storing a newly created genesis ledger on disk anyway, so it should behave just like
Ephemeralbut slower.