-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
chore: restrict commit message for running release builds #20785
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
sethkfman
wants to merge
7
commits into
main
Choose a base branch
from
chore/restrict-release-action
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+32
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
weitingsun
previously approved these changes
Oct 3, 2025
echo "BITRISE_GIT_MESSAGE: $BITRISE_GIT_MESSAGE" | ||
if ! echo "$BITRISE_GIT_MESSAGE" | grep -q "\[skip ci\] Bump version | ||
number to"; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Summary
Add validation to ensure release builds only proceed with correct commit message format.
Changes
check_release_commit_message
that validates commit messages contain the expected pattern[skip ci] Bump version number to
build_android_rc_and_upload_sourcemaps
andbuild_ios_rc_and_upload_sourcemaps
)Technical Details
BITRISE_GIT_MESSAGE
environment variable to check the commit messagegrep -q
to perform pattern matching without outputset -e
andset -o pipefail
set -x
Purpose
This change helps prevent accidental release builds by ensuring only commits with the proper version bump message format trigger the release workflow, improving CI/CD reliability and preventing unintended releases.
Files Modified
bitrise.yml
- Added commit message validation workflow stepCommit:
797ced05a2
- added check to fail release build if it doesn't contain the correct commit numberChangelog
CHANGELOG entry:
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Testing
Expected PASS
Expected FAIL
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Enforces a commit-message check before release builds and bumps all build numbers to 2649 across CI and iOS project configs.
check_release_commit_message
workflow to validateBITRISE_GIT_MESSAGE
matches[skip ci] Bump version number to
and fail with guidance otherwise.build_android_release_and_upload_sourcemaps
andbuild_ios_release_and_upload_sourcemaps
.VERSION_NUMBER
andFLASK_VERSION_NUMBER
inbitrise.yml
to2649
.CURRENT_PROJECT_VERSION
to2649
acrossMetaMask
,MetaMask-Flask
, andMetaMask-QA
configurations inios/MetaMask.xcodeproj/project.pbxproj
.Written by Cursor Bugbot for commit 2bbba2d. This will update automatically on new commits. Configure here.