feat: Implement redesigned send flow feature flag #35801
Merged
+347
−33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OGPoyraz
added
the
no-changelog
✨ Files requiring CODEOWNER review ✨✅ @MetaMask/confirmations (8 files, +286 -19)
💎 @MetaMask/metamask-assets (1 files, +6 -1)
🧪 @MetaMask/qa (1 files, +16 -0)
🖥️ @MetaMask/wallet-ux (2 files, +10 -1)
|
OGPoyraz
commented
Sep 10, 2025
Comment on lines
+1009
to
+1023
| await server | ||
| .forGet('https://client-config.api.cx.metamask.io/v1/flags') | ||
| .thenCallback(() => { | ||
| return { | ||
| ok: true, | ||
| statusCode: 200, | ||
| json: [ | ||
| { | ||
| sendRedesign: { | ||
| enabled: false, | ||
| }, | ||
| }, | ||
| ], | ||
| }; | ||
| }); |
There was a problem hiding this comment.
sendRedesign feature flag is currently used like a kill-switch. As we don't have redesigned send flow e2e tests for now, we want to disable the flow for all tests.
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| }, | ||
| ], | ||
| }; | ||
| }); |
There was a problem hiding this comment.
Bug: Mock Conflicts Cause Unpredictable Test Results
There are now two conflicting mocks for the feature flags endpoint (https://client-config.api.cx.metamask.io/v1/flags). The original mock uses withQuery() for specific flags, while the new one matches all GET requests and returns different data. This creates unpredictable test behavior and may break existing tests that rely on the original feature flags.
There was a problem hiding this comment.
I think this is not an issue if e2e tests passes - will wait and see
OGPoyraz
changed the title
📊 Page Load Benchmark ResultsCurrent Commit: 📄 https://metamask.github.io/test-dapp/Samples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Builds ready [b49a20a]
UI Startup Metrics (1260 ± 69 ms)
Benchmark value 1095 exceeds gate value 1070 for chrome browserify home mean load Benchmark value 1087 exceeds gate value 1061 for chrome browserify home mean domContentLoaded Benchmark value 256 exceeds gate value 10 for chrome browserify home mean backgroundConnect Benchmark value 24 exceeds gate value 23 for chrome browserify home mean firstReactRender Benchmark value 5 exceeds gate value 1 for chrome browserify home mean initialActions Benchmark value 839 exceeds gate value 830 for chrome browserify home mean loadScripts Benchmark value 1379 exceeds gate value 1365 for chrome browserify home p95 uiStartup Benchmark value 1217 exceeds gate value 1190 for chrome browserify home p95 load Benchmark value 1209 exceeds gate value 1180 for chrome browserify home p95 domContentLoaded Benchmark value 274 exceeds gate value 18 for chrome browserify home p95 backgroundConnect Benchmark value 17 exceeds gate value 1.2 for chrome browserify home p95 initialActions Benchmark value 956 exceeds gate value 940 for chrome browserify home p95 loadScripts Benchmark value 41 exceeds gate value 40 for chrome webpack home mean backgroundConnect Benchmark value 12 exceeds gate value 7 for chrome webpack home mean initialActions Benchmark value 99 exceeds gate value 90 for chrome webpack home p95 backgroundConnect Benchmark value 262 exceeds gate value 195 for chrome webpack home p95 getState Benchmark value 19 exceeds gate value 7 for chrome webpack home p95 initialActions Benchmark value 1436 exceeds gate value 1405 for firefox browserify home mean uiStartup Benchmark value 35 exceeds gate value 25 for firefox browserify home mean backgroundConnect Benchmark value 29 exceeds gate value 25 for firefox browserify home mean firstReactRender Benchmark value 6 exceeds gate value 1 for firefox browserify home mean initialActions Benchmark value 13 exceeds gate value 9 for firefox browserify home mean setupStore Benchmark value 1714 exceeds gate value 1660 for firefox browserify home p95 uiStartup Benchmark value 213 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 86 exceeds gate value 70 for firefox browserify home p95 backgroundConnect Benchmark value 11 exceeds gate value 2 for firefox browserify home p95 initialActions Benchmark value 51 exceeds gate value 27 for firefox browserify home p95 setupStore Benchmark value 108 exceeds gate value 100 for firefox webpack home mean domInteractive Benchmark value 33 exceeds gate value 26 for firefox webpack home mean backgroundConnect Benchmark value 44 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 4 exceeds gate value 1 for firefox webpack home mean initialActions Benchmark value 296 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 6 exceeds gate value 2 for firefox webpack home p95 initialActions Sum of mean exceeds: 421ms | Sum of p95 exceeds: 710.8ms Sum of all benchmark exceeds: 1131.8ms Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Prithpal-Sooriya
approved these changes
Sep 10, 2025
pnarayanaswamy
approved these changes
Sep 10, 2025
n3ps
approved these changes
Sep 10, 2025
jpuri
approved these changes
Sep 10, 2025
metamaskbot
added
the
release-13.4.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to add feature flag for redesigned send flow for BIP44.
As new send flow will be relying on
multichainAccountsState2(aka BIP44), the centralised hook to determine redesigned send flow has also dependency to that flag. Please seeuseRedesignedSendFlow.tsChangelog
CHANGELOG entry:
Related issues
Fixes: #35799
Manual testing steps
No user facing changes
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist