chore: indicate swap in hardware wallet confirmation page #35776

micaelae · 2025-09-10T00:54:03Z

Description

Adds translations for the AwaitingSignaturesComponent so they show "swap" or "bridge" when applicable

Changelog

CHANGELOG entry: chore: swap indicator in hardware wallet confirmation page

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/SWAPS-2821

Manual testing steps

Request swap quote using HW wallet
Signature page should indicate swap
Request bridge quote using HW wallet
Signature page should indicate bridge

Screenshots/Recordings

Before	After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

metamaskbot · 2025-09-10T00:56:18Z

✨ Files requiring CODEOWNER review ✨

🔄 @MetaMask/swaps-engineers (2 files, +20 -32)

📁 ui/
- 📁 pages/
  - 📁 bridge/
    - 📁 awaiting-signatures/
      - 📄 awaiting-signatures.tsx +19 -31
      - 📄 index.scss +1 -1

metamaskbot · 2025-09-10T01:19:38Z

📊 Page Load Benchmark Results

Current Commit: 3aac309 | Date: 9/10/2025

📄 https://metamask.github.io/test-dapp/

Samples: 100

Summary

pageLoadTime-> current mean value: 1.29s (±32ms) 🟡 | historical mean value: 1.31s ⬇️ (historical data)
domContentLoaded-> current mean value: 968ms (±28ms) 🟢 | historical mean value: 988ms ⬇️ (historical data)
firstContentfulPaint-> current mean value: 90ms (±25ms) 🟢 | historical mean value: 95ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.29s	32ms	1.26s	1.45s	1.36s	1.45s
domContentLoaded	968ms	28ms	944ms	1.11s	1.03s	1.11s
firstPaint	90ms	25ms	72ms	220ms	136ms	220ms
firstContentfulPaint	90ms	25ms	72ms	220ms	136ms	220ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Results generated automatically by MetaMask CI

metamaskbot · 2025-09-10T01:19:49Z

Builds ready [3aac309]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15
- content-script: 0
- offscreen: 0

UI Startup Metrics (1247 ± 60 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1247	1117	1417	60	1287	1358
			load	1083	958	1257	58	1118	1192
			domContentLoaded	1076	952	1249	58	1110	1178
			domInteractive	18	14	58	8	17	39
			firstPaint	646	132	1254	439	1088	1185
			backgroundConnect	249	237	280	8	254	263
			firstReactRender	23	17	46	5	24	36
			getState	14	5	86	10	16	29
			initialActions	4	0	27	4	5	11
			loadScripts	834	721	1001	57	869	931
			setupStore	9	6	21	3	10	18
	Webpack	Home	uiStartup	2057	1508	2616	280	2264	2462
			load	1647	1208	2033	210	1789	1955
			domContentLoaded	1638	1205	2013	209	1783	1931
			domInteractive	17	12	84	11	15	40
			firstPaint	169	66	378	66	201	300
			backgroundConnect	31	16	84	14	32	71
			firstReactRender	100	36	337	90	84	325
			getState	36	4	302	77	15	274
			initialActions	7	2	169	17	7	12
			loadScripts	1634	1202	2001	208	1781	1929
			setupStore	19	6	303	44	13	26
Firefox	Browserify	Home	uiStartup	1393	1198	1676	103	1447	1607
			load	1208	1057	1457	86	1270	1379
			domContentLoaded	1208	1056	1457	86	1269	1379
			domInteractive	108	32	299	51	118	231
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	31	20	99	12	34	49
			firstReactRender	27	22	70	6	29	35
			getState	6	3	86	9	6	13
			initialActions	4	1	66	7	3	11
			loadScripts	1185	1037	1429	86	1246	1359
			setupStore	9	5	53	8	8	29
	Webpack	Home	uiStartup	1540	1318	2145	160	1618	1841
			load	1316	1131	1627	122	1409	1530
			domContentLoaded	1315	1131	1627	122	1408	1530
			domInteractive	107	36	330	60	100	283
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	31	19	135	13	36	41
			firstReactRender	42	35	59	4	45	49
			getState	6	2	79	8	6	12
			initialActions	3	1	18	2	3	6
			loadScripts	1294	1115	1604	122	1388	1511
			setupStore	10	5	168	17	9	18

Benchmark value 1248 exceeds gate value 1234 for chrome browserify home mean uiStartup
Benchmark value 1084 exceeds gate value 1070 for chrome browserify home mean load
Benchmark value 1077 exceeds gate value 1061 for chrome browserify home mean domContentLoaded
Benchmark value 250 exceeds gate value 10 for chrome browserify home mean backgroundConnect
Benchmark value 24 exceeds gate value 23 for chrome browserify home mean firstReactRender
Benchmark value 5 exceeds gate value 1 for chrome browserify home mean initialActions
Benchmark value 834 exceeds gate value 830 for chrome browserify home mean loadScripts
Benchmark value 1192 exceeds gate value 1190 for chrome browserify home p95 load
Benchmark value 1185 exceeds gate value 1180 for chrome browserify home p95 firstPaint
Benchmark value 264 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 11 exceeds gate value 1.2 for chrome browserify home p95 initialActions
Benchmark value 18 exceeds gate value 17 for chrome browserify home p95 setupStore
Benchmark value 36 exceeds gate value 29 for chrome webpack home mean getState
Benchmark value 8 exceeds gate value 7 for chrome webpack home mean initialActions
Benchmark value 2462 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 274 exceeds gate value 195 for chrome webpack home p95 getState
Benchmark value 12 exceeds gate value 7 for chrome webpack home p95 initialActions
Benchmark value 31 exceeds gate value 25 for firefox browserify home mean backgroundConnect
Benchmark value 27 exceeds gate value 25 for firefox browserify home mean firstReactRender
Benchmark value 4 exceeds gate value 1 for firefox browserify home mean initialActions
Benchmark value 10 exceeds gate value 9 for firefox browserify home mean setupStore
Benchmark value 231 exceeds gate value 195 for firefox browserify home p95 domInteractive
Benchmark value 11 exceeds gate value 2 for firefox browserify home p95 initialActions
Benchmark value 29 exceeds gate value 27 for firefox browserify home p95 setupStore
Benchmark value 107 exceeds gate value 100 for firefox webpack home mean domInteractive
Benchmark value 31 exceeds gate value 26 for firefox webpack home mean backgroundConnect
Benchmark value 42 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 3 exceeds gate value 1 for firefox webpack home mean initialActions
Benchmark value 283 exceeds gate value 156 for firefox webpack home p95 domInteractive
Benchmark value 6 exceeds gate value 2 for firefox webpack home p95 initialActions
Sum of mean exceeds: 331ms | Sum of p95 exceeds: 533.8ms
Sum of all benchmark exceeds: 864.8ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 43 Bytes (0%)
ui: -357 Bytes (0%)
common: 10 Bytes (0%)

metamaskbot · 2025-09-10T17:25:12Z

📊 Page Load Benchmark Results

Current Commit: 7459217 | Date: 9/10/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.28s (±14ms) 🟡 | historical mean value: 1.29s ⬇️ (historical data)
domContentLoaded-> current mean value: 960ms (±12ms) 🟢 | historical mean value: 969ms ⬇️ (historical data)
firstContentfulPaint-> current mean value: 92ms (±16ms) 🟢 | historical mean value: 103ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.28s	14ms	1.26s	1.36s	1.30s	1.36s
domContentLoaded	960ms	12ms	943ms	1.04s	979ms	1.04s
firstPaint	92ms	16ms	76ms	172ms	136ms	172ms
firstContentfulPaint	92ms	16ms	76ms	172ms	136ms	172ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Results generated automatically by MetaMask CI

metamaskbot · 2025-09-10T17:25:19Z

Builds ready [7459217]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15
- content-script: 0
- offscreen: 0

UI Startup Metrics (1284 ± 58 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1284	1171	1443	58	1325	1370
			load	1113	1018	1268	51	1148	1202
			domContentLoaded	1105	1011	1256	51	1140	1194
			domInteractive	18	14	54	7	18	37
			firstPaint	720	92	1261	442	1125	1177
			backgroundConnect	264	246	288	8	269	277
			firstReactRender	25	17	48	6	28	40
			getState	15	5	99	11	19	30
			initialActions	6	1	65	8	7	20
			loadScripts	849	757	1005	49	880	935
			setupStore	10	6	29	4	11	18
	Webpack	Home	uiStartup	2052	1565	2863	270	2235	2478
			load	1655	1251	2196	216	1828	1982
			domContentLoaded	1640	1246	2172	218	1816	1965
			domInteractive	20	12	138	19	15	62
			firstPaint	178	69	584	76	208	318
			backgroundConnect	44	16	375	63	35	76
			firstReactRender	80	38	326	46	89	143
			getState	25	5	286	54	15	211
			initialActions	6	2	28	5	7	16
			loadScripts	1635	1244	2158	217	1813	1955
			setupStore	23	6	290	50	16	58
Firefox	Browserify	Home	uiStartup	1416	1222	1953	139	1479	1715
			load	1225	1053	1596	97	1300	1395
			domContentLoaded	1225	1053	1595	97	1300	1395
			domInteractive	107	33	394	57	104	243
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	36	18	113	21	35	93
			firstReactRender	27	23	70	6	28	37
			getState	8	3	159	17	6	15
			initialActions	3	0	38	4	3	8
			loadScripts	1198	1037	1574	95	1263	1367
			setupStore	11	4	120	15	8	27
	Webpack	Home	uiStartup	1573	1383	2115	139	1666	1853
			load	1345	1189	1622	120	1444	1590
			domContentLoaded	1344	1189	1621	120	1444	1590
			domInteractive	109	35	308	59	105	297
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	30	19	47	7	36	45
			firstReactRender	43	36	57	4	47	52
			getState	6	3	25	3	6	9
			initialActions	3	1	10	2	3	5
			loadScripts	1323	1163	1607	121	1424	1566
			setupStore	9	5	50	6	9	20

Benchmark value 1285 exceeds gate value 1234 for chrome browserify home mean uiStartup
Benchmark value 1114 exceeds gate value 1070 for chrome browserify home mean load
Benchmark value 1106 exceeds gate value 1061 for chrome browserify home mean domContentLoaded
Benchmark value 264 exceeds gate value 10 for chrome browserify home mean backgroundConnect
Benchmark value 25 exceeds gate value 23 for chrome browserify home mean firstReactRender
Benchmark value 7 exceeds gate value 1 for chrome browserify home mean initialActions
Benchmark value 850 exceeds gate value 830 for chrome browserify home mean loadScripts
Benchmark value 1370 exceeds gate value 1365 for chrome browserify home p95 uiStartup
Benchmark value 1202 exceeds gate value 1190 for chrome browserify home p95 load
Benchmark value 1194 exceeds gate value 1180 for chrome browserify home p95 domContentLoaded
Benchmark value 277 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 20 exceeds gate value 1.2 for chrome browserify home p95 initialActions
Benchmark value 18 exceeds gate value 17 for chrome browserify home p95 setupStore
Benchmark value 45 exceeds gate value 40 for chrome webpack home mean backgroundConnect
Benchmark value 2478 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 63 exceeds gate value 57 for chrome webpack home p95 domInteractive
Benchmark value 211 exceeds gate value 195 for chrome webpack home p95 getState
Benchmark value 16 exceeds gate value 7 for chrome webpack home p95 initialActions
Benchmark value 1417 exceeds gate value 1405 for firefox browserify home mean uiStartup
Benchmark value 36 exceeds gate value 25 for firefox browserify home mean backgroundConnect
Benchmark value 28 exceeds gate value 25 for firefox browserify home mean firstReactRender
Benchmark value 4 exceeds gate value 1 for firefox browserify home mean initialActions
Benchmark value 11 exceeds gate value 9 for firefox browserify home mean setupStore
Benchmark value 1715 exceeds gate value 1660 for firefox browserify home p95 uiStartup
Benchmark value 243 exceeds gate value 195 for firefox browserify home p95 domInteractive
Benchmark value 93 exceeds gate value 70 for firefox browserify home p95 backgroundConnect
Benchmark value 8 exceeds gate value 2 for firefox browserify home p95 initialActions
Benchmark value 110 exceeds gate value 100 for firefox webpack home mean domInteractive
Benchmark value 31 exceeds gate value 26 for firefox webpack home mean backgroundConnect
Benchmark value 44 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 3 exceeds gate value 1 for firefox webpack home mean initialActions
Benchmark value 297 exceeds gate value 156 for firefox webpack home p95 domInteractive
Benchmark value 52 exceeds gate value 50 for firefox webpack home p95 firstReactRender
Benchmark value 5 exceeds gate value 2 for firefox webpack home p95 initialActions
Sum of mean exceeds: 481ms | Sum of p95 exceeds: 642.8ms
Sum of all benchmark exceeds: 1123.8ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 43 Bytes (0%)
ui: -295 Bytes (0%)
common: 292 Bytes (0%)

metamaskbot · 2025-09-10T18:08:11Z

📊 Page Load Benchmark Results

Current Commit: e212807 | Date: 9/10/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.28s (±15ms) 🟡 | historical mean value: 1.28s ⬇️ (historical data)
domContentLoaded-> current mean value: 961ms (±12ms) 🟢 | historical mean value: 970ms ⬇️ (historical data)
firstContentfulPaint-> current mean value: 91ms (±13ms) 🟢 | historical mean value: 106ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.28s	15ms	1.26s	1.35s	1.30s	1.35s
domContentLoaded	961ms	12ms	944ms	1.02s	978ms	1.02s
firstPaint	91ms	13ms	72ms	160ms	116ms	160ms
firstContentfulPaint	91ms	13ms	72ms	160ms	116ms	160ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Results generated automatically by MetaMask CI

metamaskbot · 2025-09-10T18:08:23Z

Builds ready [e212807]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15
- content-script: 0
- offscreen: 0

UI Startup Metrics (1223 ± 63 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1223	1108	1552	63	1256	1323
			load	1062	965	1324	58	1094	1168
			domContentLoaded	1055	958	1312	58	1086	1161
			domInteractive	17	13	55	7	16	42
			firstPaint	700	81	1186	427	1076	1149
			backgroundConnect	249	236	271	6	251	260
			firstReactRender	24	16	42	6	25	38
			getState	14	5	55	8	18	26
			initialActions	5	0	79	8	6	10
			loadScripts	813	720	1055	56	836	917
			setupStore	10	5	32	5	12	21
	Webpack	Home	uiStartup	2019	1466	2500	264	2211	2453
			load	1606	1196	2006	201	1750	1890
			domContentLoaded	1597	1191	1995	200	1744	1878
			domInteractive	17	12	62	10	14	44
			firstPaint	163	65	523	69	194	279
			backgroundConnect	35	15	353	46	31	58
			firstReactRender	88	35	332	74	84	319
			getState	43	5	305	87	15	282
			initialActions	18	2	295	54	7	167
			loadScripts	1593	1189	1985	199	1742	1866
			setupStore	20	5	301	49	14	24
Firefox	Browserify	Home	uiStartup	1398	1182	1706	105	1452	1631
			load	1211	1042	1451	80	1260	1357
			domContentLoaded	1211	1042	1451	80	1260	1356
			domInteractive	101	34	294	46	107	220
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	30	21	78	8	33	48
			firstReactRender	27	23	43	5	30	39
			getState	6	2	53	7	6	14
			initialActions	6	0	106	17	3	28
			loadScripts	1188	1025	1427	78	1239	1328
			setupStore	10	5	84	11	8	28
	Webpack	Home	uiStartup	1545	1364	1935	142	1660	1817
			load	1329	1159	1617	129	1444	1564
			domContentLoaded	1328	1158	1617	129	1443	1563
			domInteractive	108	32	352	65	100	293
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	30	20	55	6	34	39
			firstReactRender	41	36	52	4	44	49
			getState	5	3	17	2	6	8
			initialActions	4	1	144	14	3	5
			loadScripts	1307	1141	1599	130	1425	1546
			setupStore	10	5	129	12	9	15

Benchmark value 249 exceeds gate value 10 for chrome browserify home mean backgroundConnect
Benchmark value 24 exceeds gate value 23 for chrome browserify home mean firstReactRender
Benchmark value 6 exceeds gate value 1 for chrome browserify home mean initialActions
Benchmark value 42 exceeds gate value 41 for chrome browserify home p95 domInteractive
Benchmark value 260 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 10 exceeds gate value 1.2 for chrome browserify home p95 initialActions
Benchmark value 21 exceeds gate value 17 for chrome browserify home p95 setupStore
Benchmark value 43 exceeds gate value 29 for chrome webpack home mean getState
Benchmark value 19 exceeds gate value 7 for chrome webpack home mean initialActions
Benchmark value 282 exceeds gate value 195 for chrome webpack home p95 getState
Benchmark value 167 exceeds gate value 7 for chrome webpack home p95 initialActions
Benchmark value 30 exceeds gate value 25 for firefox browserify home mean backgroundConnect
Benchmark value 28 exceeds gate value 25 for firefox browserify home mean firstReactRender
Benchmark value 7 exceeds gate value 1 for firefox browserify home mean initialActions
Benchmark value 10 exceeds gate value 9 for firefox browserify home mean setupStore
Benchmark value 220 exceeds gate value 195 for firefox browserify home p95 domInteractive
Benchmark value 28 exceeds gate value 2 for firefox browserify home p95 initialActions
Benchmark value 28 exceeds gate value 27 for firefox browserify home p95 setupStore
Benchmark value 108 exceeds gate value 100 for firefox webpack home mean domInteractive
Benchmark value 30 exceeds gate value 26 for firefox webpack home mean backgroundConnect
Benchmark value 42 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 5 exceeds gate value 1 for firefox webpack home mean initialActions
Benchmark value 293 exceeds gate value 156 for firefox webpack home p95 domInteractive
Benchmark value 5 exceeds gate value 2 for firefox webpack home p95 initialActions
Sum of mean exceeds: 306ms | Sum of p95 exceeds: 694.8ms
Sum of all benchmark exceeds: 1000.8ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 43 Bytes (0%)
ui: -251 Bytes (0%)
common: 273 Bytes (0%)

fix: HW swap confirmation page

3aac309

metamaskbot added the team-swaps-and-bridge Swaps and Bridge team label Sep 10, 2025

github-actions bot added the size-S label Sep 10, 2025

chore: add translations

d89b15d

micaelae marked this pull request as ready for review September 10, 2025 16:50

micaelae requested a review from a team as a code owner September 10, 2025 16:50

micaelae and others added 2 commits September 10, 2025 09:50

Merge branch 'main' into swaps2128-fix-hw-confirmation

15c3bed

fix: show sentAmount (total incl fees)

7459217

micaelae changed the title ~~fix: swap hardware wallet confirmation page~~ chore: indicate swap in hardware wallet confirmation page Sep 10, 2025

micaelae enabled auto-merge September 10, 2025 16:58

ghgoodreau previously approved these changes Sep 10, 2025

View reviewed changes

This comment was marked as outdated.

Sign in to view

fix: show dest swap token

e212807

micaelae dismissed ghgoodreau’s stale review via e212807 September 10, 2025 17:40

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

chore: indicate swap in hardware wallet confirmation page #35776

chore: indicate swap in hardware wallet confirmation page #35776

micaelae commented Sep 10, 2025 •

edited

Loading

Uh oh!

metamaskbot commented Sep 10, 2025 •

edited

Loading

Uh oh!

metamaskbot commented Sep 10, 2025

Uh oh!

metamaskbot commented Sep 10, 2025

Uh oh!

This comment was marked as outdated.

Uh oh!

metamaskbot commented Sep 10, 2025

Uh oh!

metamaskbot commented Sep 10, 2025

Uh oh!

metamaskbot commented Sep 10, 2025

Uh oh!

metamaskbot commented Sep 10, 2025

Uh oh!

Uh oh!

chore: indicate swap in hardware wallet confirmation page #35776

Are you sure you want to change the base?

chore: indicate swap in hardware wallet confirmation page #35776

Conversation

micaelae commented Sep 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Changelog

Related issues

Manual testing steps

Screenshots/Recordings

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

metamaskbot commented Sep 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✨ Files requiring CODEOWNER review ✨

Uh oh!

metamaskbot commented Sep 10, 2025

📊 Page Load Benchmark Results

📄 https://metamask.github.io/test-dapp/

Summary

Uh oh!

metamaskbot commented Sep 10, 2025

Uh oh!

This comment was marked as outdated.

Uh oh!

metamaskbot commented Sep 10, 2025

📊 Page Load Benchmark Results

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

metamaskbot commented Sep 10, 2025

Uh oh!

metamaskbot commented Sep 10, 2025

📊 Page Load Benchmark Results

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

metamaskbot commented Sep 10, 2025

Uh oh!

Uh oh!

micaelae commented Sep 10, 2025 •

edited

Loading

metamaskbot commented Sep 10, 2025 •

edited

Loading