feat: transaction and signature trust signal metrics #35772

imblue-dabadee · 2025-09-09T14:54:13Z

Description

This adds metrics that capture the address label and the address scan response when displayed in the UI. The metrics specifically are associated to when transactions or signatures are either approved, rejected, finalized, or submitted.

Changelog

CHANGELOG entry:

Related issues

Fixes:

Manual testing steps

Run segment locally
Trigger a transaction or signature and reject/confirm.
Observe that address_alert_response and address_label exist. The latter should only exist in anon events.

Screenshots/Recordings

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

…ctions

github-actions · 2025-09-09T14:54:24Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

metamaskbot · 2025-09-09T14:56:59Z

✨ Files requiring CODEOWNER review ✨

✅ @MetaMask/confirmations (3 files, +290 -0)

📁 ui/
- 📁 pages/
  - 📁 confirmations/
    - 📁 components/
      - 📁 confirm/
        
        📁 info/
        
        📄 info.tsx +3 -0
    - 📁 hooks/
      - 📄 useTrustSignalMetrics.test.ts +166 -0
      - 📄 useTrustSignalMetrics.ts +121 -0

metamaskbot · 2025-09-09T15:22:38Z

📊 Page Load Benchmark Results

Current Commit: 0e8769d | Date: 9/9/2025

📄 https://metamask.github.io/test-dapp/

Samples: 100

Summary

pageLoadTime-> current mean value: 1.30s (±48ms) 🟡 | historical mean value: 1.31s ⬇️ (historical data)
domContentLoaded-> current mean value: 976ms (±47ms) 🟢 | historical mean value: 984ms ⬇️ (historical data)
firstContentfulPaint-> current mean value: 91ms (±22ms) 🟢 | historical mean value: 94ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.30s	48ms	1.27s	1.71s	1.35s	1.71s
domContentLoaded	976ms	47ms	949ms	1.39s	1.02s	1.39s
firstPaint	91ms	22ms	72ms	204ms	148ms	204ms
firstContentfulPaint	91ms	22ms	72ms	204ms	148ms	204ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Results generated automatically by MetaMask CI

metamaskbot · 2025-09-09T15:22:50Z

Builds ready [0e8769d]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15
- content-script: 0
- offscreen: 0

UI Startup Metrics (1223 ± 55 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1223	1113	1409	55	1260	1309
			load	1065	974	1217	52	1090	1162
			domContentLoaded	1058	963	1201	53	1085	1156
			domInteractive	17	13	47	6	17	29
			firstPaint	659	85	1207	433	1072	1157
			backgroundConnect	251	237	273	7	255	266
			firstReactRender	24	16	50	6	24	39
			getState	12	6	36	6	15	25
			initialActions	4	0	67	9	4	11
			loadScripts	813	720	946	52	837	914
			setupStore	9	5	19	2	9	14
	Webpack	Home	uiStartup	2034	1571	2533	236	2177	2438
			load	1637	1280	1952	184	1769	1878
			domContentLoaded	1628	1275	1948	184	1758	1864
			domInteractive	17	12	76	10	15	39
			firstPaint	167	63	387	62	190	290
			backgroundConnect	39	13	342	53	31	66
			firstReactRender	79	37	329	50	80	144
			getState	33	4	299	72	14	280
			initialActions	6	2	29	5	6	23
			loadScripts	1625	1272	1946	183	1755	1852
			setupStore	19	6	289	40	13	29
Firefox	Browserify	Home	uiStartup	1389	1236	1799	106	1457	1586
			load	1207	1045	1509	81	1268	1354
			domContentLoaded	1207	1045	1508	81	1268	1354
			domInteractive	107	32	301	54	115	240
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	33	18	96	15	35	73
			firstReactRender	26	22	49	4	28	32
			getState	6	2	52	6	6	13
			initialActions	3	0	15	3	3	12
			loadScripts	1182	1024	1490	81	1234	1321
			setupStore	10	4	180	19	8	30
	Webpack	Home	uiStartup	1553	1378	2069	160	1659	1867
			load	1322	1165	1670	131	1431	1573
			domContentLoaded	1321	1164	1670	131	1430	1572
			domInteractive	106	66	301	57	95	275
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	33	20	106	13	37	51
			firstReactRender	43	34	52	4	45	48
			getState	7	2	94	10	6	13
			initialActions	3	0	10	1	3	5
			loadScripts	1297	1143	1646	131	1411	1541
			setupStore	9	5	35	4	9	16

Benchmark value 252 exceeds gate value 10 for chrome browserify home mean backgroundConnect
Benchmark value 24 exceeds gate value 23 for chrome browserify home mean firstReactRender
Benchmark value 5 exceeds gate value 1 for chrome browserify home mean initialActions
Benchmark value 267 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 11 exceeds gate value 1.2 for chrome browserify home p95 initialActions
Benchmark value 34 exceeds gate value 29 for chrome webpack home mean getState
Benchmark value 280 exceeds gate value 195 for chrome webpack home p95 getState
Benchmark value 23 exceeds gate value 7 for chrome webpack home p95 initialActions
Benchmark value 33 exceeds gate value 25 for firefox browserify home mean backgroundConnect
Benchmark value 27 exceeds gate value 25 for firefox browserify home mean firstReactRender
Benchmark value 4 exceeds gate value 1 for firefox browserify home mean initialActions
Benchmark value 11 exceeds gate value 9 for firefox browserify home mean setupStore
Benchmark value 240 exceeds gate value 195 for firefox browserify home p95 domInteractive
Benchmark value 73 exceeds gate value 70 for firefox browserify home p95 backgroundConnect
Benchmark value 12 exceeds gate value 2 for firefox browserify home p95 initialActions
Benchmark value 30 exceeds gate value 27 for firefox browserify home p95 setupStore
Benchmark value 106 exceeds gate value 100 for firefox webpack home mean domInteractive
Benchmark value 34 exceeds gate value 26 for firefox webpack home mean backgroundConnect
Benchmark value 43 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 3 exceeds gate value 1 for firefox webpack home mean initialActions
Benchmark value 275 exceeds gate value 156 for firefox webpack home p95 domInteractive
Benchmark value 51 exceeds gate value 49 for firefox webpack home p95 backgroundConnect
Benchmark value 5 exceeds gate value 2 for firefox webpack home p95 initialActions
Sum of mean exceeds: 288ms | Sum of p95 exceeds: 544.8ms
Sum of all benchmark exceeds: 832.8ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 43 Bytes (0%)
ui: 1.75 KiB (0.02%)
common: 10 Bytes (0%)

metamaskbot · 2025-09-10T03:16:10Z

❌ test-e2e-chrome-api-specs failed. View the html report here.

…ctions

metamaskbot · 2025-09-10T03:43:03Z

📊 Page Load Benchmark Results

Current Commit: ffcdfd4 | Date: 9/10/2025

📄 https://metamask.github.io/test-dapp/

Samples: 100

Summary

pageLoadTime-> current mean value: 1.31s (±47ms) 🟡 | historical mean value: 1.31s ⬆️ (historical data)
domContentLoaded-> current mean value: 985ms (±42ms) 🟢 | historical mean value: 988ms ⬇️ (historical data)
firstContentfulPaint-> current mean value: 88ms (±13ms) 🟢 | historical mean value: 95ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.31s	47ms	1.26s	1.68s	1.37s	1.68s
domContentLoaded	985ms	42ms	943ms	1.35s	1.03s	1.35s
firstPaint	88ms	13ms	72ms	156ms	116ms	156ms
firstContentfulPaint	88ms	13ms	72ms	156ms	116ms	156ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Results generated automatically by MetaMask CI

metamaskbot · 2025-09-10T03:43:18Z

Builds ready [ffcdfd4]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15
- content-script: 0
- offscreen: 0

UI Startup Metrics (1234 ± 63 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1234	1118	1418	63	1285	1332
			load	1070	964	1222	57	1112	1164
			domContentLoaded	1064	956	1211	57	1106	1153
			domInteractive	17	14	51	6	17	30
			firstPaint	698	90	1171	436	1091	1161
			backgroundConnect	249	234	269	7	253	261
			firstReactRender	26	17	54	7	29	39
			getState	15	5	79	10	18	35
			initialActions	5	0	47	7	6	16
			loadScripts	821	716	953	56	862	914
			setupStore	10	6	33	5	11	20
	Webpack	Home	uiStartup	2063	1567	2569	235	2196	2495
			load	1647	1257	2033	193	1774	1926
			domContentLoaded	1637	1245	2023	192	1764	1917
			domInteractive	19	13	106	16	15	56
			firstPaint	173	71	438	74	204	328
			backgroundConnect	40	18	355	51	34	70
			firstReactRender	90	39	326	60	91	287
			getState	31	5	314	68	15	266
			initialActions	9	2	171	17	7	22
			loadScripts	1633	1243	2020	191	1761	1905
			setupStore	26	6	308	60	15	265
Firefox	Browserify	Home	uiStartup	1363	1204	1817	121	1427	1621
			load	1178	1044	1444	89	1246	1348
			domContentLoaded	1177	1044	1444	89	1245	1348
			domInteractive	101	34	296	50	103	217
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	29	18	116	12	31	49
			firstReactRender	27	22	92	8	27	35
			getState	9	2	190	21	6	25
			initialActions	4	1	78	8	3	8
			loadScripts	1156	1027	1385	85	1227	1321
			setupStore	10	5	110	13	8	25
	Webpack	Home	uiStartup	1563	1403	2138	152	1650	1853
			load	1329	1194	1660	121	1428	1577
			domContentLoaded	1329	1194	1659	121	1428	1577
			domInteractive	105	34	317	56	96	281
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	33	21	115	10	38	42
			firstReactRender	43	33	77	5	45	49
			getState	9	3	161	21	7	16
			initialActions	4	1	158	16	3	8
			loadScripts	1304	1166	1575	121	1404	1554
			setupStore	10	5	113	11	9	21

Benchmark value 1071 exceeds gate value 1070 for chrome browserify home mean load
Benchmark value 1064 exceeds gate value 1061 for chrome browserify home mean domContentLoaded
Benchmark value 250 exceeds gate value 10 for chrome browserify home mean backgroundConnect
Benchmark value 26 exceeds gate value 23 for chrome browserify home mean firstReactRender
Benchmark value 16 exceeds gate value 15 for chrome browserify home mean getState
Benchmark value 6 exceeds gate value 1 for chrome browserify home mean initialActions
Benchmark value 261 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 35 exceeds gate value 33 for chrome browserify home p95 getState
Benchmark value 16 exceeds gate value 1.2 for chrome browserify home p95 initialActions
Benchmark value 20 exceeds gate value 17 for chrome browserify home p95 setupStore
Benchmark value 31 exceeds gate value 29 for chrome webpack home mean getState
Benchmark value 9 exceeds gate value 7 for chrome webpack home mean initialActions
Benchmark value 2495 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 266 exceeds gate value 195 for chrome webpack home p95 getState
Benchmark value 22 exceeds gate value 7 for chrome webpack home p95 initialActions
Benchmark value 265 exceeds gate value 65 for chrome webpack home p95 setupStore
Benchmark value 30 exceeds gate value 25 for firefox browserify home mean backgroundConnect
Benchmark value 27 exceeds gate value 25 for firefox browserify home mean firstReactRender
Benchmark value 4 exceeds gate value 1 for firefox browserify home mean initialActions
Benchmark value 10 exceeds gate value 9 for firefox browserify home mean setupStore
Benchmark value 217 exceeds gate value 195 for firefox browserify home p95 domInteractive
Benchmark value 25 exceeds gate value 24 for firefox browserify home p95 getState
Benchmark value 8 exceeds gate value 2 for firefox browserify home p95 initialActions
Benchmark value 105 exceeds gate value 100 for firefox webpack home mean domInteractive
Benchmark value 33 exceeds gate value 26 for firefox webpack home mean backgroundConnect
Benchmark value 43 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 5 exceeds gate value 1 for firefox webpack home mean initialActions
Benchmark value 281 exceeds gate value 156 for firefox webpack home p95 domInteractive
Benchmark value 8 exceeds gate value 2 for firefox webpack home p95 initialActions
Sum of mean exceeds: 289ms | Sum of p95 exceeds: 749.8ms
Sum of all benchmark exceeds: 1038.8ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 43 Bytes (0%)
ui: 1.83 KiB (0.02%)
common: 10 Bytes (0%)

…ctions

…ttps://github.com/MetaMask/metamask-extension into feat/metrics-on-address-trust-signals-transactions

metamaskbot · 2025-09-10T15:24:39Z

📊 Page Load Benchmark Results

Current Commit: 547cd65 | Date: 9/10/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.27s (±14ms) 🟡 | historical mean value: 1.28s ⬇️ (historical data)
domContentLoaded-> current mean value: 954ms (±12ms) 🟢 | historical mean value: 965ms ⬇️ (historical data)
firstContentfulPaint-> current mean value: 90ms (±12ms) 🟢 | historical mean value: 94ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.27s	14ms	1.25s	1.34s	1.30s	1.34s
domContentLoaded	954ms	12ms	936ms	1.01s	975ms	1.01s
firstPaint	90ms	12ms	76ms	160ms	116ms	160ms
firstContentfulPaint	90ms	12ms	76ms	160ms	116ms	160ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Results generated automatically by MetaMask CI

metamaskbot · 2025-09-10T15:24:47Z

Builds ready [547cd65]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15
- content-script: 0
- offscreen: 0

UI Startup Metrics (1242 ± 69 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1242	1119	1461	69	1278	1374
			load	1078	959	1310	67	1118	1195
			domContentLoaded	1070	956	1305	67	1111	1181
			domInteractive	18	13	48	7	17	40
			firstPaint	644	71	1233	439	1083	1169
			backgroundConnect	251	238	277	7	254	264
			firstReactRender	23	16	45	5	24	34
			getState	15	5	96	13	16	29
			initialActions	4	1	20	3	5	11
			loadScripts	826	717	1032	64	874	935
			setupStore	9	5	20	3	11	16
	Webpack	Home	uiStartup	2012	1404	2529	274	2201	2486
			load	1603	1124	2094	212	1740	1923
			domContentLoaded	1591	1117	2079	213	1730	1912
			domInteractive	19	12	103	18	15	80
			firstPaint	163	63	530	74	184	309
			backgroundConnect	42	19	350	61	35	92
			firstReactRender	95	37	430	84	85	322
			getState	27	5	288	57	14	233
			initialActions	12	2	286	36	7	17
			loadScripts	1587	1113	2069	212	1727	1910
			setupStore	25	6	294	58	14	247
Firefox	Browserify	Home	uiStartup	1555	1353	2078	147	1615	1878
			load	1339	1169	1724	105	1411	1515
			domContentLoaded	1339	1169	1723	105	1411	1515
			domInteractive	115	34	290	54	124	252
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	40	23	178	23	41	99
			firstReactRender	30	23	78	8	30	42
			getState	7	3	53	7	6	13
			initialActions	7	1	202	22	3	17
			loadScripts	1308	1143	1692	101	1367	1475
			setupStore	15	5	254	29	9	73
	Webpack	Home	uiStartup	1603	1360	2042	154	1701	1863
			load	1375	1141	1726	140	1475	1632
			domContentLoaded	1375	1140	1725	140	1475	1632
			domInteractive	104	34	368	57	98	271
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	31	21	90	9	35	41
			firstReactRender	44	31	53	4	47	51
			getState	6	2	16	2	6	9
			initialActions	5	1	133	15	3	9
			loadScripts	1352	1122	1675	140	1451	1604
			setupStore	9	6	33	4	9	13

Benchmark value 1242 exceeds gate value 1234 for chrome browserify home mean uiStartup
Benchmark value 1078 exceeds gate value 1070 for chrome browserify home mean load
Benchmark value 1071 exceeds gate value 1061 for chrome browserify home mean domContentLoaded
Benchmark value 252 exceeds gate value 10 for chrome browserify home mean backgroundConnect
Benchmark value 16 exceeds gate value 15 for chrome browserify home mean getState
Benchmark value 5 exceeds gate value 1 for chrome browserify home mean initialActions
Benchmark value 1374 exceeds gate value 1365 for chrome browserify home p95 uiStartup
Benchmark value 1195 exceeds gate value 1190 for chrome browserify home p95 load
Benchmark value 1182 exceeds gate value 1180 for chrome browserify home p95 domContentLoaded
Benchmark value 264 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 11 exceeds gate value 1.2 for chrome browserify home p95 initialActions
Benchmark value 43 exceeds gate value 40 for chrome webpack home mean backgroundConnect
Benchmark value 12 exceeds gate value 7 for chrome webpack home mean initialActions
Benchmark value 2486 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 80 exceeds gate value 57 for chrome webpack home p95 domInteractive
Benchmark value 93 exceeds gate value 90 for chrome webpack home p95 backgroundConnect
Benchmark value 233 exceeds gate value 195 for chrome webpack home p95 getState
Benchmark value 17 exceeds gate value 7 for chrome webpack home p95 initialActions
Benchmark value 247 exceeds gate value 65 for chrome webpack home p95 setupStore
Benchmark value 1555 exceeds gate value 1405 for firefox browserify home mean uiStartup
Benchmark value 1340 exceeds gate value 1245 for firefox browserify home mean load
Benchmark value 1339 exceeds gate value 1239 for firefox browserify home mean domContentLoaded
Benchmark value 116 exceeds gate value 110 for firefox browserify home mean domInteractive
Benchmark value 41 exceeds gate value 25 for firefox browserify home mean backgroundConnect
Benchmark value 30 exceeds gate value 25 for firefox browserify home mean firstReactRender
Benchmark value 7 exceeds gate value 1 for firefox browserify home mean initialActions
Benchmark value 1309 exceeds gate value 1230 for firefox browserify home mean loadScripts
Benchmark value 15 exceeds gate value 9 for firefox browserify home mean setupStore
Benchmark value 1878 exceeds gate value 1660 for firefox browserify home p95 uiStartup
Benchmark value 1515 exceeds gate value 1495 for firefox browserify home p95 load
Benchmark value 1515 exceeds gate value 1495 for firefox browserify home p95 domContentLoaded
Benchmark value 252 exceeds gate value 195 for firefox browserify home p95 domInteractive
Benchmark value 99 exceeds gate value 70 for firefox browserify home p95 backgroundConnect
Benchmark value 17 exceeds gate value 2 for firefox browserify home p95 initialActions
Benchmark value 73 exceeds gate value 27 for firefox browserify home p95 setupStore
Benchmark value 105 exceeds gate value 100 for firefox webpack home mean domInteractive
Benchmark value 31 exceeds gate value 26 for firefox webpack home mean backgroundConnect
Benchmark value 44 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 5 exceeds gate value 1 for firefox webpack home mean initialActions
Benchmark value 271 exceeds gate value 156 for firefox webpack home p95 domInteractive
Benchmark value 51 exceeds gate value 50 for firefox webpack home p95 firstReactRender
Benchmark value 9 exceeds gate value 2 for firefox webpack home p95 initialActions
Sum of mean exceeds: 764ms | Sum of p95 exceeds: 1087.8ms
Sum of all benchmark exceeds: 1851.8ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 41 Bytes (0%)
ui: 3.45 KiB (0.04%)
common: 12 Bytes (0%)

imblue-dabadee and others added 2 commits September 9, 2025 09:53

feat: transaction trust signal metrics

dedd209

Merge branch 'main' into feat/metrics-on-address-trust-signals-transa…

0e8769d

…ctions

metamaskbot added the team-product-safety Push issues to Product Safety team label Sep 9, 2025

github-actions bot added the size-M label Sep 9, 2025

imblue-dabadee added 2 commits September 9, 2025 20:53

feat: add signature support

55b1494

test: tests for tx and signatures

bef3c08

imblue-dabadee changed the title ~~feat: transaction trust signal metrics~~ feat: transaction and signature trust signal metrics Sep 10, 2025

Merge branch 'main' into feat/metrics-on-address-trust-signals-transa…

ffcdfd4

…ctions

imblue-dabadee marked this pull request as ready for review September 10, 2025 03:25

imblue-dabadee requested a review from a team as a code owner September 10, 2025 03:25

whatever1341132 approved these changes Sep 10, 2025

View reviewed changes

imblue-dabadee and others added 3 commits September 10, 2025 09:03

Merge branch 'main' into feat/metrics-on-address-trust-signals-transa…

c4ecb0c

…ctions

fix: lint

b8699e5

Merge branch 'feat/metrics-on-address-trust-signals-transactions' of h…

13eb357

…ttps://github.com/MetaMask/metamask-extension into feat/metrics-on-address-trust-signals-transactions

This comment was marked as outdated.

Sign in to view

imblue-dabadee added 3 commits September 10, 2025 09:26

chore: remove console.log

e818706

chore: fix lint

3c0e365

fix: add null safety to getTargetAddress

547cd65

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: transaction and signature trust signal metrics #35772

feat: transaction and signature trust signal metrics #35772

imblue-dabadee commented Sep 9, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Sep 9, 2025

Uh oh!

metamaskbot commented Sep 9, 2025 •

edited

Loading

Uh oh!

metamaskbot commented Sep 9, 2025

Uh oh!

metamaskbot commented Sep 9, 2025

Uh oh!

metamaskbot commented Sep 10, 2025

Uh oh!

metamaskbot commented Sep 10, 2025

Uh oh!

metamaskbot commented Sep 10, 2025

Uh oh!

This comment was marked as outdated.

Uh oh!

metamaskbot commented Sep 10, 2025

Uh oh!

metamaskbot commented Sep 10, 2025

Uh oh!

Uh oh!

feat: transaction and signature trust signal metrics #35772

Are you sure you want to change the base?

feat: transaction and signature trust signal metrics #35772

Conversation

imblue-dabadee commented Sep 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Changelog

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

github-actions bot commented Sep 9, 2025

Uh oh!

metamaskbot commented Sep 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✨ Files requiring CODEOWNER review ✨

Uh oh!

metamaskbot commented Sep 9, 2025

📊 Page Load Benchmark Results

📄 https://metamask.github.io/test-dapp/

Summary

Uh oh!

metamaskbot commented Sep 9, 2025

Uh oh!

metamaskbot commented Sep 10, 2025

Uh oh!

metamaskbot commented Sep 10, 2025

📊 Page Load Benchmark Results

📄 https://metamask.github.io/test-dapp/

Summary

Uh oh!

metamaskbot commented Sep 10, 2025

Uh oh!

This comment was marked as outdated.

Uh oh!

metamaskbot commented Sep 10, 2025

📊 Page Load Benchmark Results

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

metamaskbot commented Sep 10, 2025

Uh oh!

Uh oh!

imblue-dabadee commented Sep 9, 2025 •

edited

Loading

metamaskbot commented Sep 9, 2025 •

edited

Loading