Fix failing test issues in PRs #4414 and #4415 #4423
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR combines and fixes the issues identified in PRs #4414 and #4415, ensuring all test cases pass.
Issues Fixed
PR #4415 (OpenGL Interpolation Fix)
# type: ignore[union-attr]
comments on lines where mypy incorrectly inferred tuple types for numpy arraysPR #4414 (NumberLine AttributeError Fix)
default_numbers_to_display()
method to NumberLine class to fix AttributeError when callingget_number_mobjects()
numbers_to_exclude
parameter as requested by reviewersChanges Made
Fixed mypy type errors in
manim/mobject/opengl/opengl_mobject.py
:# type: ignore[union-attr]
to lines 2694 and 2698Fixed NumberLine AttributeError in
manim/mobject/graphing/number_line.py
:default_numbers_to_display()
methodnumbers_to_exclude
listEnhanced documentation with a new example showing
numbers_to_exclude
usageTesting
Fixes
Closes #4240 (OpenGL interpolation shape mismatch)
Closes #4244 (NumberLine AttributeError)
Original Issue Examples
The following examples from the original issues should now work:
Issue #4240 (OpenGL)
Issue #4244 (NumberLine)
This PR consolidates both fixes to ensure comprehensive test coverage and eliminates all failing checks.