rubocop fixes #198
Merged
rubocop fixes #198
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miq-bot
pushed a commit
to ManageIQ/manageiq-cross_repo-tests
that referenced
this pull request
Jul 30, 2025
From Pull Request: ManageIQ/activerecord-virtual_attributes#198
jrafanie
reviewed
Aug 7, 2025
| end | ||
|
|
||
| ActiveRecord::Base.include VirtualAttributes::VirtualTotal | ||
| ActiveSupport.on_load(:active_record) { include VirtualAttributes::VirtualTotal } |
There was a problem hiding this comment.
Should it be this in the block: ActiveRecord::Base.include VirtualAttributes::VirtualTotal?
There was a problem hiding this comment.
@jrafanie I totally worried about this.
I have gone over this in my mind many times.
I ran the code with a few options:
- commenting this out (base case to ensure it was doing something)
AS.include(AR::VT)(original)AS.on_load { AS.include(AR::VT) }AS.on_load { include(AR::VT) }
ruboco complains about both of the AS.include(AR::VT) cases.
Maybe I should just drop that change.
There was a problem hiding this comment.
yeah, I don't mind fixing warnings that are trivial. This one doesn't feel trivial. Let's get the others in on their own.
jrafanie
reviewed
Aug 7, 2025
|
update:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We may need to cross repo w/ a fix for
include@miq-bot cross-repo-test /all