-
Notifications
You must be signed in to change notification settings - Fork 466
Refactor DDP test to use multiprocessing context #3298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Refactor DDP test to use spawn context for process management.
for more information, see https://pre-commit.ci
Refactor DDP test to use spawn context for process management.
for more information, see https://pre-commit.ci
Codecov Report✅ All modified and coverable lines are covered by tests. ❌ Your project check has failed because the head coverage (31%) is below the target coverage (95%). You can increase the head coverage or adjust the target coverage.
Additional details and impacted files@@ Coverage Diff @@
## master #3298 +/- ##
========================================
- Coverage 37% 31% -6%
========================================
Files 364 349 -15
Lines 20096 19901 -195
========================================
- Hits 7520 6196 -1324
- Misses 12576 13705 +1129 🚀 New features to boost your workflow:
|
for more information, see https://pre-commit.ci
|
@Borda @SkafteNicki @justusschock for now can we revert these two prs #3166 After reverting we can merge all the pending ready prs. |
|
You can revert it in this PR and continue in fixing and then re-add it also with this PR |
Refactor DDP test to use spawn context for process management.
What does this PR do?
Fixes #<issue_number>

Use
mp.get_context('spawn')instead ofmp.spawnin tests to prevent module reimport.Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃
📚 Documentation preview 📚: https://torchmetrics--3298.org.readthedocs.build/en/3298/