Skip to content

Conversation

@adaliaramon
Copy link

@adaliaramon adaliaramon commented Oct 16, 2025

What does this PR do?

Fixes #3290. No update to the docs or new test are required, as far as I can tell. Tests are passing.

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
PR review

Memory usage is now independent of the values of the indices.

Did you have fun?

Make sure you had fun coding 🙃


📚 Documentation preview 📚: https://torchmetrics--3291.org.readthedocs.build/en/3291/

Copy link
Member

@justusschock justusschock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very Nice @adaliaramon ! Do you have comparison numbers in memory usage?

@adaliaramon
Copy link
Author

Not really but just from the example in the issue it comes down from 67 GB to basically nothing

@codecov
Copy link

codecov bot commented Oct 16, 2025

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 37%. Comparing base (fd967c0) to head (d1d0a12).

❌ Your project check has failed because the head coverage (37%) is below the target coverage (95%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #3291    +/-   ##
=======================================
- Coverage      37%     37%    -1%     
=======================================
  Files         364     349    -15     
  Lines       20096   19899   -197     
=======================================
- Hits         7520    7326   -194     
+ Misses      12576   12573     -3     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Retrieval metrics crash or use excessive memory with high-valued query indexes

2 participants