-
-
Notifications
You must be signed in to change notification settings - Fork 97
feat: sign usign twofactor_gateway #5459
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0b14fe3
to
63f7d9c
Compare
50183d2
to
37ead7f
Compare
vitormattos
added a commit
that referenced
this pull request
Sep 23, 2025
Solve #5459 (comment) Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
vitormattos
added a commit
that referenced
this pull request
Sep 23, 2025
fix #5459 (comment) Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
vitormattos
added a commit
that referenced
this pull request
Sep 23, 2025
fix #5459 (comment) Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
vitormattos
added a commit
that referenced
this pull request
Sep 23, 2025
fix #5459 (comment) Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
vitormattos
added a commit
that referenced
this pull request
Sep 23, 2025
fix: #5459 (comment) Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
vitormattos
added a commit
that referenced
this pull request
Sep 23, 2025
fix: #5459 (comment) Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
AntDavidLima
requested changes
Sep 23, 2025
The backport to # Switch to the target branch and update it
git checkout stable32
git pull origin stable32
# Create the new backport branch
git checkout -b backport/5459/stable32
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 36d259c5 4c843ae8 5a5f4d26 10898291 a795fbf1 28875646 02c1d605 d3660d41 9858fe58 260c0574 1add24e3 d3e123f0 346ec72a 67f789f9 b4535c3c 005cf495 89ef1412 56d03a7a e5d08b57 d85b0b92 e9d82fca 2b5436ae aaec06f0 5ff83601 e74af514 fbc1f1d5 fd4be101 aa15d265 e36196ba 568c1d82
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/5459/stable32 Error: Failed to push branch backport/5459/stable32: fatal: could not read Username for 'https://github.com': No such device or address Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
backportbot-libresign bot
pushed a commit
that referenced
this pull request
Oct 2, 2025
Solve #5459 (comment) Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
1 task
vitormattos
added a commit
that referenced
this pull request
Oct 2, 2025
Solve #5459 (comment) Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
vitormattos
added a commit
that referenced
this pull request
Oct 2, 2025
fix #5459 (comment) Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
vitormattos
added a commit
that referenced
this pull request
Oct 2, 2025
fix #5459 (comment) Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
vitormattos
added a commit
that referenced
this pull request
Oct 2, 2025
fix #5459 (comment) Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
vitormattos
added a commit
that referenced
this pull request
Oct 2, 2025
fix: #5459 (comment) Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
vitormattos
added a commit
that referenced
this pull request
Oct 2, 2025
fix: #5459 (comment) Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
vitormattos
added a commit
that referenced
this pull request
Oct 2, 2025
#5459 (comment) Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
vitormattos
added a commit
that referenced
this pull request
Oct 2, 2025
#5459 (comment) Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
vitormattos
added a commit
that referenced
this pull request
Oct 2, 2025
Solve #5459 (comment) Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
vitormattos
added a commit
that referenced
this pull request
Oct 2, 2025
fix #5459 (comment) Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
vitormattos
added a commit
that referenced
this pull request
Oct 2, 2025
fix #5459 (comment) Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
vitormattos
added a commit
that referenced
this pull request
Oct 2, 2025
fix #5459 (comment) Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
vitormattos
added a commit
that referenced
this pull request
Oct 2, 2025
fix: #5459 (comment) Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
vitormattos
added a commit
that referenced
this pull request
Oct 2, 2025
fix: #5459 (comment) Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
vitormattos
added a commit
that referenced
this pull request
Oct 2, 2025
#5459 (comment) Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
vitormattos
added a commit
that referenced
this pull request
Oct 2, 2025
#5459 (comment) Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
vitormattos
added a commit
that referenced
this pull request
Oct 2, 2025
Solve #5459 (comment) Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
vitormattos
added a commit
that referenced
this pull request
Oct 2, 2025
fix #5459 (comment) Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
vitormattos
added a commit
that referenced
this pull request
Oct 2, 2025
fix #5459 (comment) Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
vitormattos
added a commit
that referenced
this pull request
Oct 2, 2025
fix #5459 (comment) Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
vitormattos
added a commit
that referenced
this pull request
Oct 2, 2025
fix: #5459 (comment) Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
vitormattos
added a commit
that referenced
this pull request
Oct 2, 2025
fix: #5459 (comment) Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
vitormattos
added a commit
that referenced
this pull request
Oct 2, 2025
#5459 (comment) Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
vitormattos
added a commit
that referenced
this pull request
Oct 2, 2025
#5459 (comment) Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Allow requesting a document signature by adding a WhatsApp number (or another configured gateway) and sending the signing link directly to this number.
How to test
Administration settings
Only the gateways configured in the Twofactor Gateway app will be visible.
Sign request flow
👉 Don’t worry about the number of tabs, in most scenarios there will be no more than three. For demonstration purposes, all available methods were enabled to show compatibility with multiple signature request options.
To-do