Skip to content

Conversation

vitormattos
Copy link
Member

@vitormattos vitormattos commented Sep 22, 2025

Objective

Allow requesting a document signature by adding a WhatsApp number (or another configured gateway) and sending the signing link directly to this number.

⚠️ For WhatsApp, this implementation uses WhatsApp Web and not the WhatsApp Business API.


How to test

  • Install the twofactor_gateway app.
    • For now will be necessary to use the master branch of this app.
  • Configure a gateway (e.g., WhatsApp or SMS).
  • Go to LibreSign Administration Settings.
  • Enable the signature method related to the configured provider in Twofactor Gateway.
    • Only the providers that are configured will appear as signature methods.
  • Follow the usual steps to request a document signature.

Administration settings

Only the gateways configured in the Twofactor Gateway app will be visible.

Screenshot_20250923_094436

Sign request flow

  • The Add signer screen has been improved for a better UX and now is a dialog.
  • Signature methods are now organized into tabs.
  • Only the identity methods enabled in Administration Settings will be shown.

👉 Don’t worry about the number of tabs, in most scenarios there will be no more than three. For demonstration purposes, all available methods were enabled to show compatibility with multiple signature request options.

Screenshot_20250923_095248
  • The chosen signature method will now appear as a label under the signer’s name.
image
  • After finishing the sign request flow, the signer will receive the signing link via the selected service:
image

To-do

  • Implement unit tests
  • Implement integration tests
  • Add a new gateway to sign with Telegram at Twofactor Gateway but now using the client API of Telegram

@vitormattos vitormattos added this to the Next Major (33) milestone Sep 22, 2025
@vitormattos vitormattos requested a review from Copilot September 22, 2025 19:02
@vitormattos vitormattos self-assigned this Sep 22, 2025
@github-project-automation github-project-automation bot moved this to 0. Needs triage in Roadmap Sep 22, 2025
Copilot

This comment was marked as resolved.

@vitormattos vitormattos force-pushed the feat/sign-using-twofactor_gateway branch from 0b14fe3 to 63f7d9c Compare September 22, 2025 20:39
@vitormattos vitormattos requested a review from Copilot September 22, 2025 20:39
Copilot

This comment was marked as resolved.

@vitormattos vitormattos requested a review from Copilot September 22, 2025 21:26
Copilot

This comment was marked as resolved.

@vitormattos vitormattos force-pushed the feat/sign-using-twofactor_gateway branch from 50183d2 to 37ead7f Compare September 22, 2025 22:34
@vitormattos vitormattos requested a review from Copilot September 23, 2025 01:34
Copilot

This comment was marked as resolved.

vitormattos added a commit that referenced this pull request Sep 23, 2025
Solve #5459 (comment)

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
@vitormattos vitormattos requested a review from Copilot September 23, 2025 11:32
Copilot

This comment was marked as resolved.

@vitormattos vitormattos requested a review from Copilot September 23, 2025 11:48
Copilot

This comment was marked as resolved.

vitormattos added a commit that referenced this pull request Sep 23, 2025
fix #5459 (comment)

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
vitormattos added a commit that referenced this pull request Sep 23, 2025
fix #5459 (comment)

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
vitormattos added a commit that referenced this pull request Sep 23, 2025
fix #5459 (comment)

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Copilot

This comment was marked as resolved.

vitormattos added a commit that referenced this pull request Sep 23, 2025
fix: #5459 (comment)

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
vitormattos added a commit that referenced this pull request Sep 23, 2025
fix: #5459 (comment)

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
@github-project-automation github-project-automation bot moved this from 0. Needs triage to 1. to do in Roadmap Sep 23, 2025
@backportbot-libresign
Copy link

The backport to stable32 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable32
git pull origin stable32

# Create the new backport branch
git checkout -b backport/5459/stable32

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 36d259c5 4c843ae8 5a5f4d26 10898291 a795fbf1 28875646 02c1d605 d3660d41 9858fe58 260c0574 1add24e3 d3e123f0 346ec72a 67f789f9 b4535c3c 005cf495 89ef1412 56d03a7a e5d08b57 d85b0b92 e9d82fca 2b5436ae aaec06f0 5ff83601 e74af514 fbc1f1d5 fd4be101 aa15d265 e36196ba 568c1d82

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/5459/stable32

Error: Failed to push branch backport/5459/stable32: fatal: could not read Username for 'https://github.com': No such device or address


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

backportbot-libresign bot pushed a commit that referenced this pull request Oct 2, 2025
Solve #5459 (comment)

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
vitormattos added a commit that referenced this pull request Oct 2, 2025
Solve #5459 (comment)

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
vitormattos added a commit that referenced this pull request Oct 2, 2025
fix #5459 (comment)

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
vitormattos added a commit that referenced this pull request Oct 2, 2025
fix #5459 (comment)

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
vitormattos added a commit that referenced this pull request Oct 2, 2025
fix #5459 (comment)

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
vitormattos added a commit that referenced this pull request Oct 2, 2025
fix: #5459 (comment)

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
vitormattos added a commit that referenced this pull request Oct 2, 2025
fix: #5459 (comment)

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
vitormattos added a commit that referenced this pull request Oct 2, 2025
#5459 (comment)

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
vitormattos added a commit that referenced this pull request Oct 2, 2025
#5459 (comment)

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
vitormattos added a commit that referenced this pull request Oct 2, 2025
Solve #5459 (comment)

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
vitormattos added a commit that referenced this pull request Oct 2, 2025
fix #5459 (comment)

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
vitormattos added a commit that referenced this pull request Oct 2, 2025
fix #5459 (comment)

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
vitormattos added a commit that referenced this pull request Oct 2, 2025
fix #5459 (comment)

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
vitormattos added a commit that referenced this pull request Oct 2, 2025
fix: #5459 (comment)

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
vitormattos added a commit that referenced this pull request Oct 2, 2025
fix: #5459 (comment)

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
vitormattos added a commit that referenced this pull request Oct 2, 2025
#5459 (comment)

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
vitormattos added a commit that referenced this pull request Oct 2, 2025
#5459 (comment)

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
vitormattos added a commit that referenced this pull request Oct 2, 2025
Solve #5459 (comment)

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
vitormattos added a commit that referenced this pull request Oct 2, 2025
fix #5459 (comment)

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
vitormattos added a commit that referenced this pull request Oct 2, 2025
fix #5459 (comment)

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
vitormattos added a commit that referenced this pull request Oct 2, 2025
fix #5459 (comment)

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
vitormattos added a commit that referenced this pull request Oct 2, 2025
fix: #5459 (comment)

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
vitormattos added a commit that referenced this pull request Oct 2, 2025
fix: #5459 (comment)

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
vitormattos added a commit that referenced this pull request Oct 2, 2025
#5459 (comment)

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
vitormattos added a commit that referenced this pull request Oct 2, 2025
#5459 (comment)

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: 4. to release

Development

Successfully merging this pull request may close these issues.

3 participants